Mohan - Finishing for Vedant - Fix assign team button hover at smaller resolutions #2708

vedantg24 · 2024-09-21T19:55:18Z

Description

Fixed assign team button hover at smaller resolutions

Related PRS (if any):

This frontend PR is related to the development backend PR.
…

Main changes explained:

Updated UserTeamsTable.jsx and added the tooltip for the assign team button at smaller resolutions
…

How to test:

check into current branch
do npm install and ... to run this PR locally
Clear site data/cache
log as owner/admin user
go to dashboard→ View Profile → Teams → Check "Assign Team" button
verify that the message "This team code should only used by admin/owner, and has nothing to do with the team data mode" pops up in different resolutions

Screenshots or videos of changes:

Screen.Recording.2024-09-21.at.12.51.11.PM.mov

netlify · 2024-09-21T19:55:34Z

✅ Deploy Preview for highestgoodnetwork-dev ready!

Name	Link
🔨 Latest commit	`60ea212`
🔍 Latest deploy log	https://app.netlify.com/sites/highestgoodnetwork-dev/deploys/678336e82d23a000081d7b3b
😎 Deploy Preview	https://deploy-preview-2708--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

panchalvatneu

The message appears, and in different sizes. There is a copy editing error however; it should read: "The team should only be used by admin/owner, and has nothing to do with the team data model."

tharunaa-1 · 2024-09-25T21:36:42Z

when you hover over team the pop up comes as expected.

ashmita123

Tested PR #2708 in both light and dark modes. The "Assign Team" button tooltip appears correctly at smaller resolutions.

Screen.Recording.2024-09-26.at.9.42.01.AM.mov

beblicarl · 2024-09-26T16:37:40Z

this functionality works as intended and the code is great

Dk-21

PR 2708

@vedantg24
Tested the changes and Its working Expected.

PR-2708.mov

Vincent-space

Hi, everything works well as mentioned.

aaryaneil

Tested the PR and the hover functionality works as expected for different resolutions

khushijain03

Hi @vedantg24,

Tested the PR and the functionality works as expected for different resolutions.

Muzammil603

working as expected

Gauravmg6

It is working well as expected.

mrinalini-raghavendran19

Looks good to me!

The Ui changes work as expected. Here are screenshots of the App in light and dark mode displaying the working of the feature:

pallavithorat · 2024-10-04T00:06:00Z

Hi, It is working as expected.

ishangoel17

Verified the PR and the changes are working as expected. The team button is visible as expected on hovering. Below are the screenshots for reference:

javid679 · 2024-10-04T08:36:47Z

Verified the PR and the changes are working as expected. Below are the screenshots for the reference.

nikhilgiri0226

The tooltip was working as expected in both mobile and desktop screen sizes.

nikhilpittala16

I have tested the PR and everything works as expected.

PR.vid.46.mp4

AshishNags

Tested the PR, the message appears correctly when hovered in different resolution.

…t-smaller-resolutions

Anoushka21

Tested on smaller resolutions.

PR-2708.mp4

The pop up looks good!

lng2020

I think CI failure is due to an existing ID teamCodeAssign button.

VMD281 · 2024-10-19T01:28:14Z

Hi, I reviewed this PR and the assign team button hover works properly at smaller resolution as well.

bhavya17prakash

The assign team button hover is working as expected at smaller resolutions. Please find the screen recording of testing attached.

PR.2708.mp4

zhiminV

I have checked the feature and it work as expected

sheetalmangate · 2024-11-02T22:23:41Z

Changes are working locally. only having suggestion if message "This team code should only.." is define as constant instead.

…t-smaller-resolutions

AshritaCherlapally

This code is working as expected. Assign Team button is working as per the changes at smaller resolutions.

PR.2708.mov

anandsesha

Tested this PR and the resolution changes to the Teams section work as expected and the tooltip for the assign team button at smaller resolutions. The members modal displays correctly. Codbase looks clean. Screenshots attached.

one-community · 2025-01-12T04:28:55Z

Thank you all, merging!

Fix assign team button hover at smaller resolutions

cf0020b

panchalvatneu suggested changes Sep 21, 2024

View reviewed changes

Updated message

429c620

vedantg24 requested a review from panchalvatneu September 24, 2024 05:45

ashmita123 reviewed Sep 26, 2024

View reviewed changes

beblicarl requested review from beblicarl and removed request for panchalvatneu September 26, 2024 16:37

beblicarl previously approved these changes Sep 26, 2024

View reviewed changes

Dk-21 previously approved these changes Sep 26, 2024

View reviewed changes

one-community added the High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible label Sep 27, 2024

Vincent-space previously approved these changes Sep 28, 2024

View reviewed changes

aaryaneil previously approved these changes Sep 28, 2024

View reviewed changes

khushijain03 self-requested a review September 29, 2024 01:17

khushijain03 previously approved these changes Sep 29, 2024

View reviewed changes

Muzammil603 approved these changes Sep 29, 2024

View reviewed changes

Gauravmg6 approved these changes Sep 29, 2024

View reviewed changes

mrinalini-raghavendran19 previously approved these changes Oct 1, 2024

View reviewed changes

ishangoel17 reviewed Oct 4, 2024

View reviewed changes

nikhilgiri0226 previously approved these changes Oct 4, 2024

View reviewed changes

nikhilpittala16 previously approved these changes Oct 5, 2024

View reviewed changes

AshishNags previously approved these changes Oct 7, 2024

View reviewed changes

Merge branch 'development' into vedant-fix-assign-team-button-hover-a…

872981d

…t-smaller-resolutions

vedantg24 dismissed stale reviews from AshishNags, nikhilpittala16, and nikhilgiri0226 via 872981d October 11, 2024 02:47

Anoushka21 self-requested a review October 18, 2024 04:50

Anoushka21 previously approved these changes Oct 18, 2024

View reviewed changes

lng2020 reviewed Oct 18, 2024

View reviewed changes

bhavya17prakash previously approved these changes Oct 19, 2024

View reviewed changes

KurtisIvey added the Moved to Final Review label Oct 19, 2024

zhiminV previously approved these changes Oct 20, 2024

View reviewed changes

Merge branch 'development' into vedant-fix-assign-team-button-hover-a…

aa7c5eb

…t-smaller-resolutions

vedantg24 dismissed stale reviews from zhiminV, bhavya17prakash, Anoushka21, and NK3101 via aa7c5eb November 4, 2024 21:55

Resolve merge conflict

b06a074

AshritaCherlapally previously approved these changes Nov 6, 2024

View reviewed changes

anandsesha approved these changes Nov 10, 2024

View reviewed changes

fixmsg

ccfaf85

mohangadde1 dismissed AshritaCherlapally’s stale review via ccfaf85 December 15, 2024 06:59

mohangadde1 added 5 commits December 23, 2024 11:19

fixmsg

41bde9e

added id for Button

2243e54

fix code structure

fd4d4d1

resolve conflict

0726085

added tip in mobile view

60ea212

one-community changed the title ~~Vedant Fix assign team button hover at smaller resolutions~~ Mohan - Finishing for Vedant - Fix assign team button hover at smaller resolutions Jan 12, 2025

one-community merged commit 3fbded5 into development Jan 12, 2025
7 checks passed

one-community mentioned this pull request Jan 18, 2025

Frontend Release to Main [3.93] #3051

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Mohan - Finishing for Vedant - Fix assign team button hover at smaller resolutions #2708

Mohan - Finishing for Vedant - Fix assign team button hover at smaller resolutions #2708

vedantg24 commented Sep 21, 2024

netlify bot commented Sep 21, 2024 •

edited

Loading

panchalvatneu left a comment

tharunaa-1 commented Sep 25, 2024

ashmita123 left a comment

beblicarl commented Sep 26, 2024

Dk-21 left a comment •

edited

Loading

Vincent-space left a comment

aaryaneil left a comment

khushijain03 left a comment

Muzammil603 left a comment

Gauravmg6 left a comment

mrinalini-raghavendran19 left a comment

pallavithorat commented Oct 4, 2024

ishangoel17 left a comment

javid679 commented Oct 4, 2024

nikhilgiri0226 left a comment

nikhilpittala16 left a comment

AshishNags left a comment

Anoushka21 left a comment •

edited

Loading

lng2020 left a comment •

edited

Loading

VMD281 commented Oct 19, 2024

bhavya17prakash left a comment

zhiminV left a comment

sheetalmangate commented Nov 2, 2024

AshritaCherlapally left a comment

anandsesha left a comment

one-community commented Jan 12, 2025

Mohan - Finishing for Vedant - Fix assign team button hover at smaller resolutions #2708

Mohan - Finishing for Vedant - Fix assign team button hover at smaller resolutions #2708

Conversation

vedantg24 commented Sep 21, 2024

Description

Related PRS (if any):

Main changes explained:

How to test:

Screenshots or videos of changes:

netlify bot commented Sep 21, 2024 • edited Loading

✅ Deploy Preview for highestgoodnetwork-dev ready!

panchalvatneu left a comment

Choose a reason for hiding this comment

tharunaa-1 commented Sep 25, 2024

ashmita123 left a comment

Choose a reason for hiding this comment

beblicarl commented Sep 26, 2024

Dk-21 left a comment • edited Loading

Choose a reason for hiding this comment

PR 2708

Vincent-space left a comment

Choose a reason for hiding this comment

aaryaneil left a comment

Choose a reason for hiding this comment

khushijain03 left a comment

Choose a reason for hiding this comment

Muzammil603 left a comment

Choose a reason for hiding this comment

Gauravmg6 left a comment

Choose a reason for hiding this comment

mrinalini-raghavendran19 left a comment

Choose a reason for hiding this comment

pallavithorat commented Oct 4, 2024

ishangoel17 left a comment

Choose a reason for hiding this comment

javid679 commented Oct 4, 2024

nikhilgiri0226 left a comment

Choose a reason for hiding this comment

nikhilpittala16 left a comment

Choose a reason for hiding this comment

AshishNags left a comment

Choose a reason for hiding this comment

Anoushka21 left a comment • edited Loading

Choose a reason for hiding this comment

lng2020 left a comment • edited Loading

Choose a reason for hiding this comment

VMD281 commented Oct 19, 2024

bhavya17prakash left a comment

Choose a reason for hiding this comment

zhiminV left a comment

Choose a reason for hiding this comment

sheetalmangate commented Nov 2, 2024

AshritaCherlapally left a comment

Choose a reason for hiding this comment

anandsesha left a comment

Choose a reason for hiding this comment

one-community commented Jan 12, 2025

netlify bot commented Sep 21, 2024 •

edited

Loading

Dk-21 left a comment •

edited

Loading

Anoushka21 left a comment •

edited

Loading

lng2020 left a comment •

edited

Loading