Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Samarth B - Fixed Linting component/Teams #2947

Open
wants to merge 4 commits into
base: development
Choose a base branch
from

Conversation

samarth9201
Copy link
Contributor

Description

Fixed Linting errors in src/components/TeamMemberTasks/**

Related PRS (if any):

This frontend PR is not related to backend PR.

How to test:

  1. check into current branch
  2. do npm install and ... to run this PR locally
  3. Clear site data/cache
  4. log as any user
  5. The App should work as normal
  6. Run npm run test to make sure all tests are passing.
  7. Run npm run lint tp check linting

Copy link

netlify bot commented Dec 13, 2024

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit 22099d7
🔍 Latest deploy log https://app.netlify.com/sites/highestgoodnetwork-dev/deploys/67828f670971b800085ce5f6
😎 Deploy Preview https://deploy-preview-2947--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

anirudhsk2107
anirudhsk2107 previously approved these changes Dec 14, 2024
Copy link
Contributor

@anirudhsk2107 anirudhsk2107 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes are working properly. The tests have passed as well
Screenshot 2024-12-14 110330
Screenshot 2024-12-14 110033

Copy link

@Lakshan-K Lakshan-K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@Lakshan-K Lakshan-K self-requested a review December 15, 2024 04:23
Copy link

@Lakshan-K Lakshan-K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran the tests as instructed, and here are the results:

Test Suites: 1 failed, 214 passed, 215 total.
Tests: 1 failed, 34 skipped, 1445 passed, 1480 total.
Snapshots: 2 passed, 2 total.
Time Taken: 72.128 seconds.
The majority of the test cases passed successfully, but one test case failed. The failure needs to be investigated and resolved. Additionally, there are 34 skipped tests which might need a review to ensure they are intentionally skipped.

PR#2947

Copy link

@RashmiKY98 RashmiKY98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One test case failed and 217 passed. Request you to please look into the issue.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants