Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rishitha add details in add material #2982

Open
wants to merge 2 commits into
base: development
Choose a base branch
from

Conversation

RishithaMamidala
Copy link
Contributor

@RishithaMamidala RishithaMamidala commented Dec 25, 2024

Description

Add material form (need to add new details)

Related PRS (if any):

This frontend PR is related to the development backend PR.
To test this backend PR you need to checkout the development backend PR.

Main changes explained:

  • Update src/components/BMDashboard/AddMaterial/AddMaterial.css for including new styles
  • Update src/components/BMDashboard/AddMaterial/AddMaterial.jsx to add new details

How to test:

  1. check into current branch
  2. do npm install and ... to run this PR locally
  3. Clear site data/cache
  4. log as admin user
  5. go to http://localhost:3000/bmdashboard/materials/add
  6. log in as admin if required
  7. verify the form consists all the details.

Screenshots or videos of changes:

video2073533204.mp4

Note:

Added a field for created by

Copy link

netlify bot commented Dec 25, 2024

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit 4a298f4
🔍 Latest deploy log https://app.netlify.com/sites/highestgoodnetwork-dev/deploys/679ab25b77899d00083a2cfc
😎 Deploy Preview https://deploy-preview-2982--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

mashpotato9
mashpotato9 previously approved these changes Dec 26, 2024
Copy link

@mashpotato9 mashpotato9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ve reviewed this pr and everything worked as expected.
Screenshot 2024-12-26 at 3 48 24 PM
Screenshot 2024-12-26 at 3 48 29 PM

Copy link
Contributor

@CodewithKoushica CodewithKoushica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems to be working as expected
Screenshot 2024-12-26 at 6 14 58 PM

nikhilgiri0226
nikhilgiri0226 previously approved these changes Dec 28, 2024
Copy link
Contributor

@nikhilgiri0226 nikhilgiri0226 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed this PR and everything is working as expected. The form consisted all the details.

Material.List.-.Google.Chrome.2024-12-27.19-55-58.mp4

anirudhsk2107
anirudhsk2107 previously approved these changes Dec 28, 2024
Copy link
Contributor

@anirudhsk2107 anirudhsk2107 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The page is working as expected

Screen Shot 2024-12-28 at 11 04 49 AM

@jindaxz
Copy link

jindaxz commented Dec 28, 2024

The page is working as expected
image

@ChitraSiddharthan ChitraSiddharthan added High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible Updated This PR has been updated with a new feature labels Feb 2, 2025
Copy link

@k1guo k1guo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works as expected and have all details in video.
Thank You!#2982

Copy link

@mikelambo7 mikelambo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that material form contains all details and change works as expected
Screenshot 2025-02-04 at 2 06 43 PM

Copy link

@yany960 yany960 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the material form, all fields and styles are working as expected.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible Updated This PR has been updated with a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants