-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zhifan fix badge doesn't display on summary #3090
base: development
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed the PR. Code is fine. but not all the badges are visible upon loading the badges in weekly summary reports.
Uploading Screen Recording 2025-01-29 at 11.14.19 PM.mov…
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed the PR. everything looks good but not all the badges are visible upon loading the badges in weekly summary reports like I added few other ones but only shows a few on there Screen.Recording.2025-01-30.125355.mp4. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed the PR. Code is fine. but not all the badges are visible upon loading the badges in weekly summary reports.
Screen.Recording.2025-01-29.at.11.12.47.PM.mov
The reason why some badges don't show up is due to their configuration. |
Description
Related PRS (if any):
This frontend PR is not related to backend PR.
Use the development backend branch for testing
Main changes explained:
How to test:
npm install
and...
to run this PR locallyScreenshots or videos of changes:
Summary.mp4
Note:
Include the information the reviewers need to know.