Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zhifan fix badge doesn't display on summary #3090

Open
wants to merge 2 commits into
base: development
Choose a base branch
from

Conversation

mashpotato9
Copy link

Description

Screenshot 2025-01-27 at 2 51 42 PM

Related PRS (if any):

This frontend PR is not related to backend PR.
Use the development backend branch for testing

Main changes explained:

  • Fixed a typo when loadBages variable was passed into ReportDetails component

How to test:

  1. check into current branch
  2. do npm install and ... to run this PR locally
  3. Clear site data/cache
  4. log as admin/owner user
  5. go to profile→ assign badges→ pick a badge
  6. then go to reports -> Weekly Summaries Reports -> select week -> load badges
  7. find your name and verify the badge

Screenshots or videos of changes:

Summary.mp4

Note:

Include the information the reviewers need to know.

Copy link

netlify bot commented Jan 27, 2025

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit 59f2d55
🔍 Latest deploy log https://app.netlify.com/sites/highestgoodnetwork-dev/deploys/67a1698b75116300082020d8
😎 Deploy Preview https://deploy-preview-3090--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@ziddigsm ziddigsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the PR. Code is fine. but not all the badges are visible upon loading the badges in weekly summary reports.

Uploading Screen Recording 2025-01-29 at 11.14.19 PM.mov…

Copy link

@saigirishpabbathi saigirishpabbathi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Working as expected add this badge as instructed

@fangedShadow
Copy link

Reviewed the PR. everything looks good but not all the badges are visible upon loading the badges in weekly summary reports like I added few other ones but only shows a few on there

Screen.Recording.2025-01-30.125355.mp4

.

Copy link

@ziddigsm ziddigsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the PR. Code is fine. but not all the badges are visible upon loading the badges in weekly summary reports.

Screen.Recording.2025-01-29.at.11.12.47.PM.mov

@mashpotato9
Copy link
Author

mashpotato9 commented Feb 3, 2025

Reviewed the PR. Code is fine. but not all the badges are visible upon loading the badges in weekly summary reports.

The reason why some badges don't show up is due to their configuration.
Screenshot 2025-02-03 at 6 43 35 PM
Screenshot 2025-02-03 at 6 44 21 PM
For example, these two badges have showReport set to null and false hence they don't appear in the summary report. I have double checked with Jae and had the showReport check removed. Now every badges will show up regardless of their config @ziddigsm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants