Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honglin fix wbs button align issue #3096

Merged
merged 2 commits into from
Jan 30, 2025
Merged

Conversation

honglinchen0524
Copy link
Contributor

@honglinchen0524 honglinchen0524 commented Jan 30, 2025

Description

This PR fixes the layout issue of the button group in the WBS tasks view. Previously, the buttons were rendered evenly across the top of the page. This fix aligns the buttons in a row on the left, improving the layout.
image

Related PRS:

This fix addresses an unintended side effect introduced by PR #2714, which added a .button-group CSS class that overrode the media query originally created in PR #2795 for larger screens.

Main changes explained:

Updated WBSTasks.jsx:

  • Changed the className of the button container from button-group to wbs-button-group
    Updated wbs.css:
  • Added a new wbs-button-group class with appropriate styling for all screen sizes.

How to test:

  1. check into current branch
  2. do npm install and ... to run this PR locally
  3. Clear site data/cache
  4. log as admin user
  5. go to dashboard→ Other Links→ Projects→ WBS
  6. If the project doesn't have a WBS, add a new one
  7. Click on the WBS
  8. Verify that the buttons are aligned in a row on the left as the following screenshot

Screenshots or videos of changes:

Before:
image

After:
image

Copy link

netlify bot commented Jan 30, 2025

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit a8c5ba5
🔍 Latest deploy log https://app.netlify.com/sites/highestgoodnetwork-dev/deploys/679ad5923027da00087e61f5
😎 Deploy Preview https://deploy-preview-3096--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@honglinchen0524 honglinchen0524 changed the title fix wbs button align issue Honglin fix wbs button align issue Jan 30, 2025
@honglinchen0524 honglinchen0524 marked this pull request as ready for review January 30, 2025 01:35
@one-community one-community merged commit d2e0e41 into development Jan 30, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants