Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geeta - 'Generate Summary Intro' button's visibility #3097

Merged
merged 2 commits into from
Feb 1, 2025

Conversation

geetamatkar
Copy link
Contributor

@geetamatkar geetamatkar commented Jan 30, 2025

Description

Screenshot 2025-01-30 at 1 06 50 PM

Related PRS (if any):

None

Main changes explained:

  • Updated UserProfile.jsx

How to test:

  1. check into current branch
  2. do npm install and ... to run this PR locally
  3. Clear site data/cache
  4. log as admin/owner/manager user
  5. go to profile page
  6. verify if 'Generate Summary Intro' is visible for above user roles.

Screenshots or videos of changes:

Screenshot 2025-01-30 at 1 11 28 PM

Copy link

netlify bot commented Jan 30, 2025

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit 33564e1
🔍 Latest deploy log https://app.netlify.com/sites/highestgoodnetwork-dev/deploys/679d6c7753df340008a4b0d8
😎 Deploy Preview https://deploy-preview-3097--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@geetamatkar geetamatkar changed the title Fixed 'Generate Summary Intro' button's visibility Geeta - 'Generate Summary Intro' button's visibility Jan 30, 2025
@fangedShadow
Copy link

It shows the button for admin/mangaer and doesn't for test role. Also I didn't have the owner account so, i couldn't check with that but the other works.
Screenshot 2025-01-30 143138
Screenshot 2025-01-30 143221
Screenshot 2025-01-30 143611

Copy link

@ziddigsm ziddigsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The button is available for Manager and Admin roles. However, I could not check it for Owner as I dont have access to it.

Screenshot 2025-01-30 at 7 34 03 PM Screenshot 2025-01-30 at 7 37 42 PM

ziddigsm
ziddigsm previously approved these changes Jan 31, 2025
Copy link

@ziddigsm ziddigsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the changes

@lalith425
Copy link

I have checked for manager role "Genarate Summary Role" is visible. And its not visible for Volunteer role.

Checked the code base and can see its configured to be visible only for Owner, Administrator, Manager
ChangesLooksGood
NotVisibleForVolunteerRole
VisibleForManagerRole

Copy link
Contributor

@NazaninHashemian NazaninHashemian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the changes, and everything looks good! The "Generate Summary Intro
Generate Summary Intro button
npm install
Uploading switch to pr-3097 branch .png…
" button has been added to the profile page, which wasn't there before. It’s working as expected, and the page looks more complete now with this addition. Great job!

@geetamatkar geetamatkar dismissed stale reviews from NazaninHashemian and ziddigsm via 33564e1 February 1, 2025 00:36
@luisarevalo21
Copy link
Contributor

luisarevalo21 commented Feb 1, 2025

Hello @geetamatkar
Thanks for working on this, I was able to test with a manager, admin and owner account.
All 3 accounts can see the button. Great work!

However, clicking the button with an admin was the only one allowed to copy to clipboard, the rest didn't copy anything. I wonder if it has to do with the user logged in and if they have the rights. I don't remember how i set it up originally.

Screenshot 2025-01-31 at 4 44 53 PM Screenshot 2025-01-31 at 4 46 06 PM Screenshot 2025-01-31 at 4 46 57 PM

@one-community one-community merged commit 75830fa into development Feb 1, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants