Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sriram fix owner manage all permissions #3099

Open
wants to merge 2 commits into
base: development
Choose a base branch
from

Conversation

sri0606
Copy link
Contributor

@sri0606 sri0606 commented Jan 31, 2025

Description

image

Related PRS (if any):

This frontend PR is related to the backend PR1221

Main changes explained:

  • Update file PermissionListItem togglePermission logic to manage default/immutable perms.
  • All the perms can be editable by Owner
  • Previously the Add/Delete button was disabled even if logged in user is Owner. Now they are enabled for Owner and can make changes.

How to test:

  1. check into current branch
  2. do npm install and ... to run this PR locally
  3. Clear site data/cache
  4. log as Owner user
  5. go to dashboard→ Other Links→ Permission Mangement→ Manage User permissions
  6. Go to an user, check to make sure none of perms' Add/Delete buttons are disabled
  7. verify delete/add works
  8. verify this new feature works in dark mode

@sri0606 sri0606 added the do not review Do not review or look at code without full context label Jan 31, 2025
Copy link

netlify bot commented Jan 31, 2025

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit df642f9
🔍 Latest deploy log https://app.netlify.com/sites/highestgoodnetwork-dev/deploys/67a677543684300008587744
😎 Deploy Preview https://deploy-preview-3099--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant