Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Neha - Timer popout feature #3112

Open
wants to merge 2 commits into
base: development
Choose a base branch
from
Open

Conversation

neha3010
Copy link

@neha3010 neha3010 commented Feb 1, 2025

Description

Tried to implement a feature that pops out the timer into a separate window on top. I managed to open the timer with all its components in a separate window. Couldn't figure out how to make it stay on top all the time (like YouTube's Picture in picture feature).

Related PRS (if any):

Main changes explained:

  • Added a new file (TimerPopout.jsx) to implement the Timer popout feature.
  • Integrated the TimerPopout in Timer.jsx

How to test:

  1. check into current branch
  2. do npm install and ... to run this PR locally
  3. Clear site data/cache
  4. log as admin user
  5. Dashboard -> click on the popout (external link symbol)
  6. Check if the Timer is opening in a separate window or not.
  7. Check with different browsers.

Screenshots or videos of changes:

Screen.Recording.2025-02-01.at.2.04.28.AM.mov

Note:

Include the information the reviewers need to know.

Copy link

netlify bot commented Feb 1, 2025

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit 457c34b
🔍 Latest deploy log https://app.netlify.com/sites/highestgoodnetwork-dev/deploys/679e9dd0c2692f00080104fe
😎 Deploy Preview https://deploy-preview-3112--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@neha3010 neha3010 changed the title neha-Timer popout feature implementation. Neha - Timer popout feature Feb 1, 2025
Copy link

@fangedShadow fangedShadow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality wise it is working properly. I think you might need to change the size of the window as it was not properly showing all the things and also implement the design. For the popup, you cannot do it a new window(unless you are using electron, which we are not), you will have to use a div with functionality if you want to implement the youtube video pop feature(they use a video tag which has a attribute of popup).

Screen.Recording.2025-02-03.130525.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants