Feature/plugin custom graphql scalars #47

TimLehner · 2020-02-01T22:07:34Z

This is an expansion of the ideas in PR #46

- ensures this is a non-breaking change

- Initially had the whole plugin toggled.

FluorescentHallucinogen · 2020-02-02T07:39:15Z

@TimLehner 👍 BTW, have you seen #10 (comment)? It would be really nice to have plug-ins for input fields that are object types with child fields, not only scalars (leafs). Is this possible with this PR?

FluorescentHallucinogen · 2020-02-02T07:40:31Z

Also found #31.

FluorescentHallucinogen

See https://www.npmjs.com/package/graphql-iso-date for more info about the difference between Date and DateTime custom GraphQL scalars. 😉

FluorescentHallucinogen · 2020-02-02T07:53:48Z

src/plugins/graphql-scalar-inputs/README.md

+const customISODateTypeHandler = {
+  render: (arg, styleConfig, onChangeHandler) => (
+    <input
+      type="date"


I believe it should be "datetime-local" instead of "date", because you use .toISOString().

FluorescentHallucinogen · 2020-02-02T07:54:25Z

src/plugins/graphql-scalar-inputs/README.md

+      }}
+    />
+  ),
+  canProcess: (arg) => arg && arg.type && arg.type.name ===  'Date',


I believe it should be "DateTime" instead of "Date", because you use .toISOString().

FluorescentHallucinogen · 2020-02-02T07:55:03Z

src/plugins/graphql-scalar-inputs/bundled/DateInput.js

+import * as React from 'react';
+
+function canProcess(arg) {
+  return arg && arg.type && arg.type.name ===  'Date';


I believe it should be "DateTime" instead of "Date", because you use .toISOString().

The DateInput is distinct from the example in the README which demonstrates adding additional handlers not bundled with the explorer.

This bundled plugin is just a direct implementation of the Date input in the POC PR.

FluorescentHallucinogen · 2020-02-02T07:55:13Z

src/plugins/graphql-scalar-inputs/bundled/DateInput.js

+function render(arg, styleConfig, onChangeHandler) {
+  return (
+    <input
+      type="date"


I believe it should be "datetime-local" instead of "date", because you use .toISOString().

TimLehner · 2020-02-02T16:20:56Z

@FluorescentHallucinogen
I have added support for more complex types, the plugins need to return some React.Element-like object. I've added an example implementation of a plugin for a Complex Number type in the README

- changes in editor now reflected in inputs

FluorescentHallucinogen · 2020-04-04T12:26:16Z

@sgrove @dwwoelfel Please review this pull request.

dwwoelfel

This is great!

@TimLehner can you move everything into the Explorer.js file.

We're trying to keep a single file because some people copy Explorer.js and drop it into their code base for development or because they want to make small customizations for their environment.

TimLehner · 2020-04-15T17:35:34Z

I can, but I wonder if it would be better to provide that sort of functionality using typescript compiler options?

I could look at some tsconfig to make the output dist/ a single file? Feels better to me to generate that then force the code structure one way

baohouse · 2020-04-22T03:18:59Z

@TimLehner can you move everything into the Explorer.js file.
We're trying to keep a single file because some people copy Explorer.js and drop it into their code base for development or because they want to make small customizations for their environment.

I don't mind dropping a folder in if it means the code is split up according to the classes used. It makes updating easier when we can preserve original code in files that don't need customization.

…into feature/plugin-custom-graphql-scalars

TimLehner · 2020-04-22T09:07:32Z

This is great!

@TimLehner can you move everything into the Explorer.js file.

We're trying to keep a single file because some people copy Explorer.js and drop it into their code base for development or because they want to make small customizations for their environment.

Have moved everything into Explorer.js as requested. I will look into making a new PR to split Explorer.js up into the individual classes responsible, and typescript-ify my contributions.

The goal is to be able to provide the best of both worlds:

A structured project to allow easier contributions from multiple people, minimising merge conflicts
A method of building a single Explorer.js file, still in ES2016 or similar, for users who wish to drag-and-drop this single file into their implementation and make small tweaks
The existing ./dist, which packages the minified .js in commonjs

This will be a separate PR, so I think this can now be closed and merged if there are no further comments -- would it be nice if the plugins are based on an abstract base class so it is clear for third-parties how to implement their own plugins?

FluorescentHallucinogen · 2020-05-13T07:28:17Z

@dwwoelfel PTAL.

FluorescentHallucinogen · 2020-12-02T07:14:15Z

@sgrove @dwwoelfel Ping.

…mespace

TimLehner added 8 commits January 10, 2020 17:07

add a 'deprecated' class to fields which have been marked as such

0e2b43e

Merge branch 'master' of https://github.com/OneGraph/graphiql-explorer

9fe6dd3

Refactor existing behaviour into seperate method

025c824

Introduce custom scalar input plugin manager

745e400

Create example DateInput plugin based on PR OneGraph#46

9c3647a

Only enable bundled plugins if requested.

014ec5b

- ensures this is a non-breaking change

update readme for custom-graphql-scalars plugin

77348c4

[bugfix] only disable the bundled plugins

ce1453f

- Initially had the whole plugin toggled.

FluorescentHallucinogen reviewed Feb 2, 2020

View reviewed changes

TimLehner added 5 commits February 2, 2020 11:06

typo

47f6bae

Date -> DateTime

7673dc1

[bugfix] if manager is null explorer could break

c48ce5f

show checkbox if rendered by plugin

ae727bd

Add support for complex types

0180b44

TimLehner added 4 commits February 2, 2020 18:04

update example inputs when query text changes

433d702

- changes in editor now reflected in inputs

disable example input plugin if not selected

48ae2f0

typo

7d597f7

update plugin readme

ead2b1d

FluorescentHallucinogen mentioned this pull request Feb 4, 2020

Ideas for improving the Developer Experience and Feature Discoverability #10

Open

dwwoelfel self-requested a review April 15, 2020 17:06

dwwoelfel reviewed Apr 15, 2020

View reviewed changes

FluorescentHallucinogen mentioned this pull request Apr 21, 2020

Custom argument inputs #31

Open

TimLehner added 2 commits April 22, 2020 08:49

Merge changes from master

064c579

Move everything into Explorer.js following review

8062b6b

Merge branch 'master' of https://github.com/OneGraph/graphiql-explorer …

7674eba

…into feature/plugin-custom-graphql-scalars

TimLehner mentioned this pull request Apr 24, 2020

array (list) input #32

Open

fix broken merge

f684f5c

dboakes-ag added 4 commits March 2, 2022 14:18

Merge remote-tracking branch 'upstream/master'

3e99795

Merge branch 'master' into feature/plugin-custom-graphql-scalars

93cd44b

[sc-28504] Bump version and ensure package.json has agrimetrics in na…

437b01d

…mespace

[sc-28504] Fix ScalarInputPluginManager handler and bump version

65c0290

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/plugin custom graphql scalars #47

Feature/plugin custom graphql scalars #47

TimLehner commented Feb 1, 2020

FluorescentHallucinogen commented Feb 2, 2020

FluorescentHallucinogen commented Feb 2, 2020

FluorescentHallucinogen left a comment

FluorescentHallucinogen Feb 2, 2020

FluorescentHallucinogen Feb 2, 2020

FluorescentHallucinogen Feb 2, 2020

TimLehner Feb 2, 2020

FluorescentHallucinogen Feb 2, 2020

TimLehner commented Feb 2, 2020

FluorescentHallucinogen commented Apr 4, 2020

dwwoelfel left a comment

TimLehner commented Apr 15, 2020

baohouse commented Apr 22, 2020 •

edited

Loading

TimLehner commented Apr 22, 2020

FluorescentHallucinogen commented May 13, 2020

FluorescentHallucinogen commented Dec 2, 2020

Feature/plugin custom graphql scalars #47

Are you sure you want to change the base?

Feature/plugin custom graphql scalars #47

Conversation

TimLehner commented Feb 1, 2020

FluorescentHallucinogen commented Feb 2, 2020

FluorescentHallucinogen commented Feb 2, 2020

FluorescentHallucinogen left a comment

Choose a reason for hiding this comment

FluorescentHallucinogen Feb 2, 2020

Choose a reason for hiding this comment

FluorescentHallucinogen Feb 2, 2020

Choose a reason for hiding this comment

FluorescentHallucinogen Feb 2, 2020

Choose a reason for hiding this comment

TimLehner Feb 2, 2020

Choose a reason for hiding this comment

FluorescentHallucinogen Feb 2, 2020

Choose a reason for hiding this comment

TimLehner commented Feb 2, 2020

FluorescentHallucinogen commented Apr 4, 2020

dwwoelfel left a comment

Choose a reason for hiding this comment

TimLehner commented Apr 15, 2020

baohouse commented Apr 22, 2020 • edited Loading

TimLehner commented Apr 22, 2020

FluorescentHallucinogen commented May 13, 2020

FluorescentHallucinogen commented Dec 2, 2020

baohouse commented Apr 22, 2020 •

edited

Loading