Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4 fix: base max send error OK-27575 #4543

Merged
merged 1 commit into from
May 6, 2024
Merged

v4 fix: base max send error OK-27575 #4543

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/engine/src/vaults/impl/evm/Vault.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,9 +140,10 @@ import type {
import type { IRpcTxEvm } from './types';
import type { IJsonRpcRequest } from '@onekeyfe/cross-inpage-provider-types';

const OPTIMISM_NETWORKS: string[] = [
const EVM_L2_NETWORKS_REQUIRE_L1_FEE: string[] = [
OnekeyNetwork.optimism,
OnekeyNetwork.toptimism,
OnekeyNetwork.base,
];

const ERC721 = ERC721MetadataArtifact.abi;
Expand Down Expand Up @@ -1271,7 +1272,7 @@ export default class Vault extends VaultBase {

// For L2 networks with L1 fee.
let baseFeeValue = '0';
if (OPTIMISM_NETWORKS.includes(this.networkId)) {
if (EVM_L2_NETWORKS_REQUIRE_L1_FEE.includes(this.networkId)) {
// Optimism & Optimism Kovan
// call gasL1Fee(bytes) of GasPriceOracle at 0x420000000000000000000000000000000000000F
const txData = ethers.utils.serializeTransaction({
Expand Down
Loading