fix: query params isn't replaced by Endpoint class so no need to set … #33
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Fix #32
Details
Motivation
query parameters that are passed to the Endpoint class were not removed.
For example; When calling the
export_events
function, the API client send a request to the URL likehttps://onesignal.com/api/v1/notifications/4133437f-888c-4a6c-82af-a1d320ad8b31/export_events?app_id={app_id}
. As app_id is not replaced, so that the server response 400 bad request error.Scope
export_events
andexport_players
will be fix.OPTIONAL - Other
Testing
Manual testing
Confirm that the below code works
Checklist
Overview
Testing
Final pass