feat: add update and delete item routes to BaseAPI and improve monito…

…r ID handling in WorkspaceNotificationRuleService
OneUptime · Feb 14, 2025 · 8ec0825 · 8ec0825
1 parent 4d083f9
commit 8ec0825
Show file tree

Hide file tree

Showing 2 changed files with 50 additions and 1 deletion.
diff --git a/Common/Server/API/BaseAPI.ts b/Common/Server/API/BaseAPI.ts
@@ -131,6 +131,31 @@ export default class BaseAPI<
       },
     );
 
+    router.post(
+      `${new this.entityType().getCrudApiPath()?.toString()}/:id/update-item`,
+      UserMiddleware.getUserMiddleware,
+      async (req: ExpressRequest, res: ExpressResponse, next: NextFunction) => {
+        try {
+          await this.updateItem(req, res);
+        } catch (err) {
+          next(err);
+        }
+      },
+    );
+
+
+    router.get(
+      `${new this.entityType().getCrudApiPath()?.toString()}/:id/update-item`,
+      UserMiddleware.getUserMiddleware,
+      async (req: ExpressRequest, res: ExpressResponse, next: NextFunction) => {
+        try {
+          await this.updateItem(req, res);
+        } catch (err) {
+          next(err);
+        }
+      },
+    );
+
     // Delete
     router.delete(
       `${new this.entityType().getCrudApiPath()?.toString()}/:id`,
@@ -144,6 +169,30 @@ export default class BaseAPI<
       },
     );
 
+    router.post(
+      `${new this.entityType().getCrudApiPath()?.toString()}/:id/delete-item`,
+      UserMiddleware.getUserMiddleware,
+      async (req: ExpressRequest, res: ExpressResponse, next: NextFunction) => {
+        try {
+          await this.deleteItem(req, res);
+        } catch (err) {
+          next(err);
+        }
+      },
+    );
+
+    router.get(
+      `${new this.entityType().getCrudApiPath()?.toString()}/:id/delete-item`,
+      UserMiddleware.getUserMiddleware,
+      async (req: ExpressRequest, res: ExpressResponse, next: NextFunction) => {
+        try {
+          await this.deleteItem(req, res);
+        } catch (err) {
+          next(err);
+        }
+      },
+    );
+
     this.router = router;
     this.service = service;
   }

diff --git a/Common/Server/Services/WorkspaceNotificationRuleService.ts b/Common/Server/Services/WorkspaceNotificationRuleService.ts
@@ -249,7 +249,7 @@ export class Service extends DatabaseService<Model> {
 
       const monitorLabels: Array<Label> =
         await MonitorService.getLabelsForMonitors({
-          monitorIds: alert?.monitor?.id! ? [alert?.monitor?.id!] : [],
+          monitorIds: alert?.monitor?.id ? [alert?.monitor?.id] : [],
         });
 
       return {