Free of charge calls

[wzrdtales]

Free of charge calls

We currently call this logic via an external webhook, but figured this may be interesting for everyone.

The idea is that outbound calls that are not lifted, are not charged (as it always has been since history). The important part is that the calling side is dropping the call, before it hits the mailbox. Combining this with all modern smartphones capability to set a different ringtone per number, improves the yearly call bill significantly.

Pull Request Checklist:

• Please make sure all jobs pass before requesting a review.
• Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if such).
• Have you lint your code locally before submission?
• Did you write tests where appropriate?

Related Issue?

Screenshots (if appropriate):

[wzrdtales]

See only this commit, 824a873

It seems your project is not yet working with automatically enforced code styles which is why my editor had to enforce them.

[simlarsen]

I dont think this is the right appraoch. Maybe run a cron job everyday to check the call status and refund the balance? You can create a job in the worker project. Maybe also create a new column - something like isPaymentFinalized (boolean) and you can tick that off in the cron.

Please let me know if this helps!

[wzrdtales]

You didn't seem to understand the actual logic. This wont work, you can't refund balance.

This addition does not cause any costs, b/c the call never gets lifted. The problem is, that even if the participant doesn't lift, it will hit the mailbox. So the initiating side must drop the call themself to avoid that and get a completely free outbound call.

We use this massively already a long time and dropped costs down to sub 1% what we were consuming before we made that change.

[wzrdtales]

I agree, this should be an optional option. But I don't know your codebase well enough and don't have the time to finish the change and make it configurable, so this is rather a suggestion than a full PR.

[wzrdtales]

If interested to getting this in, this could be easily put behind a config var of course @simlarsen I hope you understood by my comment what this actually does.

[simlarsen]

Happy to put this in but this needs to be architected right.

[wzrdtales]

Not much architecture here, this would simply need a toggle and eventually a configurable call drop timeout both as a setting on the frontend side, please be more concise, what are you missing?