Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTC: Enable blue light schedule to work with real RTC #1706

Merged
merged 16 commits into from
Dec 22, 2024

Conversation

stianKristensen
Copy link
Contributor

@stianKristensen stianKristensen commented Nov 24, 2024

  • Enables the blue light schedule to work for the new Miyoo Mini V4 with RTC (or earlier revisions that have been modded).
  • Prevent the blue light filter from always starting enabled on boot when the schedule says it should be off.
  • Removed the network requirement, instead opting to blindly follow the current clock time if schedule is enabled.

Copy link
Member

@Aemiii91 Aemiii91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like if we checked for the noTimeRestore flag, instead of showing the options for all.

@stianKristensen
Copy link
Contributor Author

I'd like if we checked for the noTimeRestore flag, instead of showing the options for all.

Good idea! I'll change the checks for the miyoo mini + that I removed to instead check the noTimeRestore.

@stianKristensen
Copy link
Contributor Author

Correction: I'll add to the checks so that they will be visible if it is a mini plus OR the noTimeRestore exists (so non-rtc mini plus with network time still works)

@stianKristensen
Copy link
Contributor Author

I've added what you suggested, along with making sure the schedule options are always available if the .blf flag exists. This allows Miyoo Mini Plus owners without RTC to still turn off the schedule if they've turned off the network sync.

Copy link
Member

@Aemiii91 Aemiii91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@Aemiii91 Aemiii91 enabled auto-merge December 22, 2024 18:34
@Aemiii91 Aemiii91 added this pull request to the merge queue Dec 22, 2024
Merged via the queue into OnionUI:main with commit c6a23ae Dec 22, 2024
3 checks passed
@Aemiii91 Aemiii91 added bug in onion Something isn't working enhancement New or improved feature and removed bug in onion Something isn't working labels Dec 24, 2024
@Aemiii91 Aemiii91 changed the title Enable blue light schedule to work for Miyoo Minis with RTC Enable blue light schedule to work with real RTC Dec 24, 2024
@Aemiii91 Aemiii91 changed the title Enable blue light schedule to work with real RTC RTC: Enable blue light schedule to work with real RTC Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New or improved feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants