Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GDB-9900 Cluster rejoin #33

Merged
merged 1 commit into from
Apr 9, 2024
Merged

GDB-9900 Cluster rejoin #33

merged 1 commit into from
Apr 9, 2024

Conversation

viktor-ribchev
Copy link
Contributor

@viktor-ribchev viktor-ribchev commented Apr 3, 2024 •
edited
Loading

Added check if 1 node is deployed, don't setup DNS records and attempt to create cluster

Description

  • Implemented cluster rejoin procedure
  • Introduced stable network names
  • Improved cluster creations.
  • Refactored the attach disk logic to handle multiple disks in the same AZ.
  • Added README and diagrams displaying the logic in the scripts.
  • Improved logging.
  • Other improvements

Related Issues

GDB-9900

Changes

  • Refactored the user data scripts
  • Added node rejoin
  • Included deploy_monitoring and deploy_backup variables to the graphdb module to be used in the user data scripts.
  • Added README and diagrams
  • Renamed some variables to be descriptive.

Screenshots (if applicable)

N/A

Checklist

  • I have tested these changes thoroughly.
  • My code follows the project's coding style.
  • I have added appropriate comments to my code, especially in complex areas.
  • All new and existing tests passed locally.

@viktor-ribchev viktor-ribchev force-pushed the GDB-10061_cluster_rejoin branch 2 times, most recently from 3f104d8 to 1f23444 Compare April 5, 2024 07:44
@viktor-ribchev viktor-ribchev marked this pull request as ready for review April 5, 2024 07:45
yaskoo
yaskoo reviewed Apr 5, 2024
View reviewed changes
main.tf Outdated Show resolved Hide resolved
modules/graphdb/templates/01_disk_management.sh.tpl Show resolved Hide resolved
modules/graphdb/templates/01_disk_management.sh.tpl Show resolved Hide resolved
modules/graphdb/templates/02_dns_provisioning.sh.tpl Outdated Show resolved Hide resolved
modules/graphdb/templates/08_node_rejoin.sh.tpl Outdated Show resolved Hide resolved
@viktor-ribchev viktor-ribchev force-pushed the GDB-10061_cluster_rejoin branch 3 times, most recently from 990a540 to e4b9235 Compare April 8, 2024 07:26
@viktor-ribchev viktor-ribchev requested a review from yaskoo April 8, 2024 07:41
@simonzhekoff @viktor-ribchev
GDB-9900 Cluster rejoin
0d4dc1f 
Added check if 1 node is deployed, don't setup DNS records and attempt to create cluster
Variable renaming and tidying up
Refactored the user data scripts
@viktor-ribchev viktor-ribchev force-pushed the GDB-10061_cluster_rejoin branch from 36ceead to 0d4dc1f Compare April 9, 2024 05:04
@viktor-ribchev viktor-ribchev merged commit e8192b6 into main Apr 9, 2024
2 checks passed
@viktor-ribchev viktor-ribchev deleted the GDB-10061_cluster_rejoin branch April 9, 2024 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaskoo yaskoo yaskoo approved these changes

@ivorusev ivorusev Awaiting requested review from ivorusev

@mihailradkov mihailradkov Awaiting requested review from mihailradkov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@viktor-ribchev @yaskoo @simonzhekoff