-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replacer for *Dat2Obj.py* and *Dat2ObjTex.py* #1
base: master
Are you sure you want to change the base?
Conversation
*Dat2Obj.py* and *Dat2ObjTex.py* are now replaced by *dat2obj.py*, and renamed with a *_old* suffix to avoid issues on case unsensitive file systems. *dat2obj.py* uses a more object oriented approach to convert files. It can handle mono or multi-textured files, whith or without NORMALS section. More details can be found in `dat2obj.md`.
@JensAyton @Kaks @AnotherCommander Anyone still active here or is this project dead? |
Hi, sorry for not getting back to you earlier. The project's activity is much reduced these days. The reason I did not comment on this PR earlier is that I do not have Python experience and do not feel qualified to comment on the code. Plus, I cannot test the PR and was hoping that someone else might be able to do a review. Just a couple of quick questions for now, a) What is the minimum version of Python required to be able to run this? b) Can it be built also on Windows and, if yes, are there any dependencies we need to be aware of? |
No problem. I read in the readme that Merging a PR locally to test it is possible using git command line. The minimum version of Python is 2.7.3. It can be converted for Python 3 by using I also created a release on my fork, where are instructions to run on Linux. |
The test helper program `build_otis.py` now rely on `pbPlist` library instead of `openstep_parser`. The test script `test_dat2obj.sh` has been updated to install `pbPlist` in the virtual environment.
Changed test program dependency and formated `dat2obj.py`.
I am unable to test this PR on Windows. The Python I have is too old (2.4) and no time to get it set up with more updated versions right now. There are also some new dependencies introduced, which makes things more complicated for me. I would appreciate it if someone else did this review. @LaChal Could you maybe test under Windows and confirm that this PR can be built and works there too? |
Badly, I don't have a working Windows system right now on my side. |
We have a forum comment from a user who tried the proposed updates. It looks like the conversion to .obj is not entirely clean. More details here: http://www.aegidian.org/bb/viewtopic.php?p=263131#p263131 |
Hmmm... |
@AnotherCommander I think I have the answer for the issue you linked.
|
* The `test_dat2obj.py` program can be used to test `dat2obj.py`. Call it with the python interpreter, or use the dedicated scripts `test_dat2obj.bat` or `test_dat2obj.sh`, according to your OS. By default, this program will use your Oolite installation to double convert the `.dat` models files to `.obj` and `.mtl` ones. The `.dat` files are copied in dedicated folders before conversion, so the game ones are not used directly. Note that the test program will tell that the tests failed for 35 files. This is (for now) the expected behaviour. See `test_dat2obj.py` itself for more details about the test scenario and usage options. * Removed the forced lower case conversion on file names in `dat2obj.py`. * Enhanced `build_otis.py`. * Fixed some typos and docstrings.
Release v1.0.0
Dat2Obj.py and Dat2ObjTex.py are now replaced by dat2obj.py, and renamed with a _old suffix to avoid issues on case unsensitive file systems.
dat2obj.py uses a more object oriented approach to convert files.
It can handle mono or multi-textured files, whith or without NORMALS section.
More details can be found in
dat2obj.md
.