Mtab check optional #1486
Closed
Mtab check optional #1486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deixx
force-pushed
the
mtab-check-optional
branch
from
62f8881 to
5256127
Compare
Deixx
force-pushed
the
mtab-check-optional
branch
4 times, most recently
from
b9733ea to
fd7662c
Compare
system (e.g. in certain container images). This blocks stop/remove operations. With making this check optional the duty of checking mounts falls to kernel. Test modified to check operations with and without mtab. Signed-off-by: Daniel Madej <[email protected]>
Deixx
force-pushed
the
mtab-check-optional
branch
from
fd7662c to
a2f20d1
Compare
mmichal10
requested changes
Sep 10, 2024
Comment on lines
+1837
to
1845
| cas_printf(LOG_ERR, | ||
| "Can't stop cache instance %d. Device %s is mounted!\n", | ||
| cache_id, mstruct->mnt_fsname); | ||
| } else { | ||
| cas_printf(LOG_ERR, | ||
| "Can't remove core %d from cache %d." | ||
| " Device %s is mounted!\n", | ||
| core_id, cache_id, mstruct->mnt_fsname); | ||
| } |
There was a problem hiding this comment.
This function should only check whether cores are mounted. The error messages should be printed by the caller function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.