-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of tests for exported object serial feature #1584
Open
katlapinka
wants to merge
2
commits into
Open-CAS:master
Choose a base branch
from
katlapinka:kasiat/lvm-by-serial
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Katarzyna Treder <[email protected]>
Hello @katlapinka! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2024-11-25 19:55:54 UTC |
katlapinka
force-pushed
the
kasiat/lvm-by-serial
branch
from
November 13, 2024 13:48
704da35
to
1a7c13d
Compare
Deixx
reviewed
Nov 15, 2024
test/functional/tests/volumes/test_many_lvms_on_many_cores_by_serial.py
Outdated
Show resolved
Hide resolved
test/functional/tests/volumes/test_many_lvms_on_many_cores_by_serial.py
Outdated
Show resolved
Hide resolved
test/functional/tests/volumes/test_many_lvms_on_many_cores_by_serial.py
Outdated
Show resolved
Hide resolved
Deixx
reviewed
Nov 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rename PR as well
Signed-off-by: Katarzyna Treder <[email protected]>
katlapinka
force-pushed
the
kasiat/lvm-by-serial
branch
from
November 25, 2024 19:55
1a7c13d
to
dbf8e08
Compare
katlapinka
changed the title
Implementation of tests for CAS device serial feature
Implementation of tests for exported object serial feature
Nov 25, 2024
Deixx
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs:
Open-CAS/test-framework#32