Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cbuild2cmake] Avoid run-always executes cyclic dependencies #228

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

brondani
Copy link
Collaborator

Fixes #227

Copy link
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

Copy link
Contributor

Test Results

  4 files  ±0   20 suites  ±0   1s ⏱️ ±0s
 72 tests ±0   72 ✅ ±0  0 💤 ±0  0 ❌ ±0 
288 runs  ±0  288 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 399f64f. ± Comparison against base commit 8af6042.

Copy link

codeclimate bot commented Nov 19, 2024

Code Climate has analyzed commit 399f64f and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 88.1% (0.0% change).

View more on Code Climate.

@brondani brondani merged commit acfd5c7 into main Nov 20, 2024
16 checks passed
@brondani brondani deleted the avoid-runalways-cyclic-deps branch November 20, 2024 08:08
soumeh01 added a commit to Open-CMSIS-Pack/cmsis-toolbox that referenced this pull request Nov 21, 2024
## Changes
- Updated test cases as per changes in
Open-CMSIS-Pack/cbuild2cmake#229 and
Open-CMSIS-Pack/cbuild2cmake#228

## Checklist
<!-- Put an `x` in the boxes. All tasks must be completed and boxes
checked before merging. -->

- [ ] 🤖 This change is covered by unit tests as required.
- [ ] 🤹 All required manual testing has been performed.
- [x] 🛡️ Security impacts have been considered.
- [ ] 📖 All documentation updates are complete.
- [x] 🧠 This change does not change third-party dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Commit 8af6042 causes cyclic dependencies if multiple RunAlways targets exist
2 participants