Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New multirow separator #22

Merged
merged 7 commits into from
Sep 3, 2024
Merged

New multirow separator #22

merged 7 commits into from
Sep 3, 2024

Conversation

prakaa
Copy link
Member

@prakaa prakaa commented Sep 3, 2024

Closes #21

@codecov Codecov
Copy link

codecov bot commented Sep 3, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
src/isp_workbook_parser/config_model.py 100.00% <ø> (ø)
src/isp_workbook_parser/parser.py 84.66% <100.00%> (+4.00%) ⬆️
src/isp_workbook_parser/read_table.py 100.00% <100.00%> (ø)

@nick-gorman
Copy link
Member

Agreed the '_' should be a more robust separator when merging header rows.

@nick-gorman nick-gorman merged commit 22a8ec8 into main Sep 3, 2024
15 checks passed
@nick-gorman nick-gorman deleted the new-multirow-separator branch September 3, 2024 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make separator for multi-row headers more robust
2 participants
@prakaa @nick-gorman