Refine fill forward strategy to handle issue with summary table #24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the fill forward strategy for multi-header rows meant that single header columns after multi-headers would be mislabelled (see issue below for an example). This seems to only occur in the summary tables
To fix this, fill forward is manually implemented to:
a) If value in corresponding column of the preceding header row is nan, then forward fill
b) else leave as nan
This should work for 3+ header rows, but AEMO only seems to have at most 3 header rows at the moment
Ran all tests and produced all output - note that all changes are only new separator (this is branched off that PR) and removing wrong merged headers in summary files. So for easiest comparison, diff these changes with those of the new separator branch
Closes #23