Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #1912

Merged
merged 4 commits into from
Dec 3, 2024
Merged

Update README.md #1912

merged 4 commits into from
Dec 3, 2024

Conversation

darthmooguy
Copy link

Add warning for Windows for ARM users.

Add warning for Windows for ARM users.
@darthmooguy
Copy link
Author

darthmooguy commented Apr 23, 2024

Happened to me today, I would have liked to see this in the readme, not in the issues after the fact. (#966)

README.md Outdated
@@ -23,6 +23,9 @@ You can find the latest stable version here:

[![GitHub All Releases](https://img.shields.io/github/downloads/Open-Shell/Open-Shell-Menu/total?style=for-the-badge&color=4bc2ee&logo=github)](https://github.com/Open-Shell/Open-Shell-Menu/releases/latest)

### ⚠️ WARNING FOR WINDOWS ARM USERS ⚠️
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about just Warning for Windows for ARM users?
Without the rather annoying all caps?
I guess those exclamation icons are enough to draw the attention.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or maybe just Windows for ARM compatibility ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I can change the title to be less intense! It bricked my VM so I was a bit agitated at the time 😛

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add a few checks for the installer to only work on tested environments. There's been a few reports of the installer doing bad things to recent versions of windows.

@Itsamejonah
Copy link

almost no one uses windows arm, but only on mobile

This was referenced Nov 14, 2024
@Open-Shell Open-Shell deleted a comment from Neustradamus Nov 17, 2024
@XenHat
Copy link
Member

XenHat commented Nov 17, 2024

almost no one uses windows arm, but only on mobile

Thank you for your feedback. We'll look into it.

@ge0rdi ge0rdi merged commit 040d3d0 into Open-Shell:master Dec 3, 2024
1 check failed
@Neustradamus
Copy link

@ge0rdi: Good job! Thanks for the merging of @darthmooguy PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants