-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: automatically use the correct runtime #201
Draft
R1kaB3rN
wants to merge
24
commits into
Open-Wine-Components:main
Choose a base branch
from
R1kaB3rN:no-umu-version
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Metadata will be used to dynamically download and change to the correct runtime
R1kaB3rN
force-pushed
the
no-umu-version
branch
from
October 6, 2024 01:42
b82d381
to
76764b0
Compare
GloriousEggroll
force-pushed
the
main
branch
3 times, most recently
from
October 19, 2024 16:42
3ac4479
to
92f26b1
Compare
GloriousEggroll
force-pushed
the
main
branch
2 times, most recently
from
October 22, 2024 16:13
98672e2
to
25f5311
Compare
GloriousEggroll
force-pushed
the
main
branch
3 times, most recently
from
October 22, 2024 17:43
1f950cc
to
c4893a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #178 and #154
Changes
__init__.py
.Description
This PR changes the launcher so it automatically changes to the correct runtime for the set Proton each launch to prepare for future updates, and to downloaded the appropriate runtime for new installations.
Currently, umu-launcher only officially supports running in the sniper container and using Proton versions compiled for it. However, not everyone will be using the latest runtime/Proton, and some clients (e.g., Steam, Heroic Games Launcher) allow their users to use obsolete Proton builds to run their games. More importantly, since updating to the latest SLR is currently a manual procedure, users may not be able to run their games in case the latest downloaded Proton and the installed SLR are out of sync as we download them in parallel and don't attempt to sync them.
Now, when the user sets an obsolete Proton build or when the runtime gets updated to a major version, umu-launcher will change to its intended runtime if it was already downloaded. This will prepare for the event when a major SLR is released (e.g., steamrt4) and when users still has some games configured in their client application to run in sniper. In that event, users will be responsible for deleting the obsolete runtimes at
$HOME/.local/share/umu
.TODO: