Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fixes for COJ Gunslinger on Steam #75

Merged
merged 2 commits into from
May 9, 2024

Conversation

Tiagoquix
Copy link
Contributor

@Tiagoquix Tiagoquix commented May 8, 2024

  • Add wmp11 to fix cutscenes
  • Limit to 31 cores

Please let me know if I missed something. Thanks!

wmp11 and 31 cores fixes are due to user reports:

ValveSoftware/Proton#366

https://www.protondb.com/app/204450

It seems like both wmp9 and wmp11 work, so we should prefer the newer version.
I am using wmp11 and it works normally.

Tiagoquix added 2 commits May 8, 2024 15:07
- Add wmp11 to fix cutscene audio
- Limit to 31 cores
@R1kaB3rN R1kaB3rN merged commit 77bc435 into Open-Wine-Components:master May 9, 2024
1 check passed
@Tiagoquix
Copy link
Contributor Author

@R1kaB3rN Hi there. Could you please clarify for me if the following is needed for future contributions? Thanks in advance.

#pylint: disable=C0103

from protonfixes import util

@R1kaB3rN
Copy link
Member

@R1kaB3rN Hi there. Could you please clarify for me if the following is needed for future contributions? Thanks in advance.

#pylint: disable=C0103

from protonfixes import util

The first statement is not strictly necessary when it comes to applying fixes, so users shouldn't need to worry about it.

As for the second statement, it depends but you will most likely need it to do anything useful since all the functionality to apply a fix are currently in that file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants