-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WRC 4 added #85
WRC 4 added #85
Conversation
Let's make it run out of the box.
gamefixes-steam/256330.py
Outdated
util.protontricks('xact') | ||
|
||
# Audio breaks above 60 fps | ||
util.set_environment('DXVK_FRAME_RATE', '60') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of setting this environment variable, a PR should be made for this upstream in DXVK.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
audio bug is not linux related, should I still ask DXVK to limit framerate upstream?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, please make a PR to DXVK as everyone will benefit and you're certain that playing the game at 60+ FPS will break audio. Also, I'm not even too sure we allow fixes to set this variable as this fix would be the only one that sets this environment variable in this project.
gamefixes-steam/256330.py
Outdated
#Black screen without it | ||
util.protontricks('d3dx9_42') | ||
util.protontricks('d3dx9_43') | ||
util.protontricks('faudio') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this solve? Using the faudio verb will install downgraded faudio DLLs and use them. Are you sure this is necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried without it, looks like it works now, without xact, audio sliders do not work in game. I also forgot to add wmp11 to the script to make background videos work.
I'll merge this ASAP once you make a DXVK PR and remove that environment variable. See https://github.com/doitsujin/dxvk/blob/master/src/util/config/config.cpp for examples. |
Let's make it run out of the box.