Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WRC 4 added #85

Merged
merged 3 commits into from
Jul 5, 2024
Merged

WRC 4 added #85

merged 3 commits into from
Jul 5, 2024

Conversation

ToRRent1812
Copy link
Contributor

Let's make it run out of the box.

Let's make it run out of the box.
util.protontricks('xact')

# Audio breaks above 60 fps
util.set_environment('DXVK_FRAME_RATE', '60')
Copy link
Member

@R1kaB3rN R1kaB3rN Jul 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of setting this environment variable, a PR should be made for this upstream in DXVK.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

audio bug is not linux related, should I still ask DXVK to limit framerate upstream?

Copy link
Member

@R1kaB3rN R1kaB3rN Jul 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please make a PR to DXVK as everyone will benefit and you're certain that playing the game at 60+ FPS will break audio. Also, I'm not even too sure we allow fixes to set this variable as this fix would be the only one that sets this environment variable in this project.

#Black screen without it
util.protontricks('d3dx9_42')
util.protontricks('d3dx9_43')
util.protontricks('faudio')
Copy link
Member

@R1kaB3rN R1kaB3rN Jul 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this solve? Using the faudio verb will install downgraded faudio DLLs and use them. Are you sure this is necessary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried without it, looks like it works now, without xact, audio sliders do not work in game. I also forgot to add wmp11 to the script to make background videos work.

@R1kaB3rN
Copy link
Member

R1kaB3rN commented Jul 2, 2024

I'll merge this ASAP once you make a DXVK PR and remove that environment variable.

See https://github.com/doitsujin/dxvk/blob/master/src/util/config/config.cpp for examples.

@R1kaB3rN R1kaB3rN merged commit c6012c0 into Open-Wine-Components:master Jul 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants