Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[haskell-http-client] Update haskell-http-client generator to Aeson 2.x #11535

Closed
wants to merge 2 commits into from

Conversation

mrandri19
Copy link
Contributor

@mrandri19 mrandri19 commented Feb 6, 2022

Due to a denial-of-service vulnerability of aeson-1.x, we would like to update to aeson-2.x.

This PR includes the 1-line change in Core.hs necessary to upgrade aeson to the new version.

If the PR points to the wrong branch, tell me and I will fix it.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@mrandri19 mrandri19 changed the title 5.4.x [haskell-http-client] Update haskell-http-client generator to Aeson 2.x Feb 6, 2022
@wing328 wing328 added this to the 6.0.0 milestone Feb 6, 2022
@wing328
Copy link
Member

wing328 commented Feb 6, 2022

@mrandri19 thanks for the PR. Can you please file the PR against the latest master (the upcoming v6.0.0 release) instead?

cc @jonschoning

@jonschoning jonschoning self-assigned this Feb 6, 2022
@mrandri19 mrandri19 changed the base branch from 5.4.x to master February 6, 2022 21:40
@mrandri19
Copy link
Contributor Author

mrandri19 commented Feb 7, 2022

thanks for the PR. Can you please file the PR against the latest master (the upcoming v6.0.0 release) instead?

Thanks for anwering so fast! I have changed the base branch to master.

Not sure why the CircleCI tests are failing though.

@wing328
Copy link
Member

wing328 commented Mar 18, 2022

For the CircieCI failure, please merge the latest master into branch and it should fix it.

@wing328
Copy link
Member

wing328 commented May 4, 2022

@jonschoning may I know if you've time to review this change? We will release v6.0.0 in late May and include this change if possible.

@jonschoning
Copy link
Contributor

sure, will review in the next couple days

@mrandri19
Copy link
Contributor Author

mrandri19 commented May 5, 2022

For the CircieCI failure, please merge the latest master into branch and it should fix it.

I will re-merge it in a couple days, to have all checks pass in time for the review

@jonschoning
Copy link
Contributor

udpated in #12309

@jonschoning jonschoning closed this May 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants