Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azazel Purchasables - Elixiers | 30€ Bounty #2110

Closed
l34Um1 opened this issue Mar 23, 2018 · 6 comments
Closed

Azazel Purchasables - Elixiers | 30€ Bounty #2110

l34Um1 opened this issue Mar 23, 2018 · 6 comments
Labels
lua

Comments

@l34Um1
Copy link
Collaborator

l34Um1 commented Mar 23, 2018 •
edited
Loading

Azazel

Azazel is a fallen angel that runs a shop in the center area of the map. This is a major new feature. This issue contains the first set of purchasable items.

Unlike the regular shop, Azazel does not trade in gold. Instead all items in his shop are only available for purchase via cores. Purchasables listed as Tier 1 will require a Tier 1 core and a 100 gold recipe, Tier 2 requires a Tier 2 core and a 100g recipe, etc.

Elixiers

Elixiers are one time consumables that give a temporary buff. They can't be stacked in inventory and only one may be active at a time. We currently have 3 Elixiers and each Elixier comes at 4 power levels. All Elixiers last one minute.

Tier 1

  • Elixier of Sustainability 1: +20 Health Regen, gain 20% damage reduction while stunned.
  • Elixier of Burst 1: +40 Movement Speed, after attacking your next 4 Attacks within 10 seconds gain +250 attack speed. This attack speed burst may only trigger once.
  • Elixier of the Hybrid 1: + 5 Mana Regen, after casting a spell your next attack deals 100 bonus magic damage.

Tier 2

  • Elixier of Sustainability 2: +30 Health Regen, gain 30% damage reduction while stunned.
  • Elixier of Burst 2: +80 Movement Speed, after attacking your next 6 Attacks within 10 seconds gain +250 attack speed. This attack speed burst may only trigger once.
  • Elixier of the Hybrid 2: + 10 Mana Regen, after casting a spell your next attack deals 200 bonus magic damage.

Tier 3

  • Elixier of Sustainability 3: +40 Health Regen, gain 40% damage reduction while stunned.
  • Elixier of Burst 3: +120 Movement Speed, after attacking your next 8 Attacks within 10 seconds gain +250 attack speed. This attack speed burst may only trigger once.
  • Elixier of the Hybrid 3: + 15 Mana Regen, after casting a spell your next attack deals 300 bonus magic damage.

Tier 4

  • Elixier of Sustainability 4: +50 Health Regen, gain 50% damage reduction while stunned.
  • Elixier of Burst 4: +160 Movement Speed, after attacking your next 10 Attacks within 10 seconds gain +250 attack speed. This attack speed burst may only trigger once.
  • Elixier of the Hybrid 4: + 20 Mana Regen, after casting a spell your next attack deals 400 bonus magic damage.

All Elixiers need KVs for their corresponding effects as well as their duration.

Related Issues

Azazel Baseline functionality #2107
Azazel Model #2108
Azazel Voice #2109
Azazel Purchasables

Bug Bounty Guideline
This was referenced Mar 23, 2018
Open
Open
Closed
Closed
Open
@l34Um1 l34Um1 changed the title Azazel Purchasables - Elixiers Azazel Purchasables - Elixiers | 30€ Bounty Mar 25, 2018
@dedpul24
Copy link

Can Elixers be shared/used on other heroes besides self?

@l34Um1
Copy link
Collaborator Author

l34Um1 commented Mar 25, 2018

No

@fcalife
Copy link
Contributor

fcalife commented Mar 26, 2018

I'd like to claim this one to work on.

@l34Um1 l34Um1 added lua and removed lua labels Mar 27, 2018
@fcalife
Copy link
Contributor

fcalife commented Mar 29, 2018

I have been slow due to setting up the project locally for the first time, but should have this ready in the next 24h. Sorry for the delay.

@l34Um1
Copy link
Collaborator Author

l34Um1 commented Apr 1, 2018

Have you made any progress? Anything you can show?

@fcalife
Copy link
Contributor

fcalife commented Apr 2, 2018

Made a PR which should cover everything, tell me if I missed any of it.

@l34Um1 l34Um1 added the Claimed label Apr 2, 2018
@fcalife fcalife mentioned this issue Apr 14, 2018
Merged
carlosrpg pushed a commit that referenced this issue May 17, 2018
@fcalife @carlosrpg
Azazel Purchasables - Elixiers (#2156)
385cf58 
* Implementing #2110

* Added summon KV and extra abilities

Assumed 300 MS for farmer and 1.0 turn rate for all summons.

* Added azazel summon item entries and basic functionality

* Finished implementing #2111

- Used "funny" names for the summons, just change them if you don't like them or think they're not clear enough.
- Summon stats are tied to their actual stat block in npc_units_custom; the values in the item just change tooltips.
- The Farmer's cleave stats are tied to the ability's KV, not the item's; again, the item's KVs just change tooltips.

If the whole KV/tooltip thing is a bother, it can be changed, but I thought it was outside the scope of the issue, since the current behavior is easier to implement and consistent with (almost) every vanilla summon ability in the game.

* travis

* missing tooltip for modifier "dota_tooltip_modifier_azazel_summon_farmer_innate"
 - it's a hidden modifier that needs no tooltip.
* item/ability ID conflicts
 - fixed
* "cost is set correctly in kv for item_elixier_sustain_4"
 - I assume this means incorrectly. The items all cost 100g (recipe) + their core's cost (1500/2500/3500/4500) so I don't see the error here, but i set everything to 100 anyway, assuming cores have no real value.
* "[item] has reverse compatible upgrade [core x]"
 - If I understood correctly, this is intended.
* blah blah whitespace
 - fixed
* blah unused variable
 - fixed

Also made the items temporarily purchasable in the regular shop.

* seems like travis' "next free ID" is a fat old lie

fixed conflicting item/ability IDs

* test

test

* Fix Travis
@mikibun mikibun closed this as completed Jun 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
lua
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@fcalife @l34Um1 @dedpul24 @mikibun