-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tool] Add code quality tools to ci #36
Open
savacano28
wants to merge
100
commits into
release/1.11.0
Choose a base branch
from
issue/1982
base: release/1.11.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
savacano28
force-pushed
the
issue/1982
branch
from
December 19, 2024 11:18
5305761
to
6d70514
Compare
savacano28
changed the title
[tool] Update pipeline to fail whenever there is a warning during com…
[tool] Add code quality tools to ci
Dec 23, 2024
heditar
reviewed
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add the next code quality tools to CI:
→ Cargo check
→ Cllippy: lint checks https://github.com/rust-lang/rust-clippy
→ Rustfmt: format code
→ Cargo Audit: check security dependencies
→ Cargo Test
After apply these tools some files were updated with the recommendations from these tools.
For windows AMD, I had a conflict with the rust version (1.82.0 so for that I uninstalle it). I version 1.8.3 is installed.
For windows ARM, I had a conflict with the cargo audit with repo github public, so I unset url variable and after I set in its original state.
Related issues
Checklist