Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tool] Add code quality tools to ci #36

Open
wants to merge 100 commits into
base: release/1.11.0
Choose a base branch
from
Open

Conversation

savacano28
Copy link

@savacano28 savacano28 commented Dec 18, 2024

Proposed changes

Add the next code quality tools to CI:

→ Cargo check
→ Cllippy: lint checks https://github.com/rust-lang/rust-clippy
→ Rustfmt: format code
→ Cargo Audit: check security dependencies
→ Cargo Test

After apply these tools some files were updated with the recommendations from these tools.

For windows AMD, I had a conflict with the rust version (1.82.0 so for that I uninstalle it). I version 1.8.3 is installed.
For windows ARM, I had a conflict with the cargo audit with repo github public, so I unset url variable and after I set in its original state.

Related issues

  • Close Obas #1982 & #1981

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

@savacano28 savacano28 self-assigned this Dec 18, 2024
@savacano28 savacano28 changed the title [tool] Update pipeline to fail whenever there is a warning during com… [tool] Add code quality tools to ci Dec 23, 2024
@savacano28 savacano28 changed the base branch from main to release/1.11.0 December 23, 2024 18:23
@savacano28 savacano28 marked this pull request as ready for review December 24, 2024 15:54
src/main.rs Outdated Show resolved Hide resolved
src/api/register_agent.rs Show resolved Hide resolved
CODE_QUALITY.md Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants