Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] add emphasis on configuring rabbitmq postgres minio (#89) #95

Merged
merged 5 commits into from
Jan 31, 2025

Conversation

antoinemzs
Copy link
Contributor

@antoinemzs antoinemzs commented Jan 29, 2025

Proposed changes

  • Add emphasis on the mandatory aspect of configuring RabbitMQ, PostgreSQL and MinIO, with links to relevant docs sections.

Fix #89

Signed-off-by: Antoine MAZEAS <[email protected]>
docs/deployment/installation.md Show resolved Hide resolved
docs/deployment/installation.md Outdated Show resolved Hide resolved
docs/deployment/installation.md Outdated Show resolved Hide resolved
docs/deployment/installation.md Show resolved Hide resolved
docs/deployment/installation.md Show resolved Hide resolved
@RomuDeuxfois
Copy link
Member

Some collected feedbacks, maybe this can help:

Even for the installation part, the docs only mention cloning, editing application.properties and running java -jar file.jar . However, we also need to setup minIO, RabbitMQ, Postgres, and then add all these details into the application.properties . This should be included in the documentation.

In documentation section reg the application configuration would be better for easy understanding

Signed-off-by: Antoine MAZEAS <[email protected]>
@antoinemzs
Copy link
Contributor Author

Some collected feedbacks, maybe this can help:

Even for the installation part, the docs only mention cloning, editing application.properties and running java -jar file.jar . However, we also need to setup minIO, RabbitMQ, Postgres, and then add all these details into the application.properties . This should be included in the documentation.

In documentation section reg the application configuration would be better for easy understanding

Do you feel this is not addressed?

@RomuDeuxfois
Copy link
Member

Some collected feedbacks, maybe this can help:
Even for the installation part, the docs only mention cloning, editing application.properties and running java -jar file.jar . However, we also need to setup minIO, RabbitMQ, Postgres, and then add all these details into the application.properties . This should be included in the documentation.
In documentation section reg the application configuration would be better for easy understanding

Do you feel this is not addressed?

I think the first one is handled.
The second one need to be handled in the openbas repo direclty, like you said.

Signed-off-by: Antoine MAZEAS <[email protected]>
@antoinemzs antoinemzs merged commit 378368d into main Jan 31, 2025
@antoinemzs antoinemzs deleted the add/minio_rabbitmq_postgres branch January 31, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add doc on setting up : RabbitMQ , MinIO, Postgres
2 participants