Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[implant] decode payload with rust #26

Merged
merged 2 commits into from
Dec 10, 2024
Merged

[implant] decode payload with rust #26

merged 2 commits into from
Dec 10, 2024

Conversation

MarineLeM
Copy link
Contributor

@MarineLeM MarineLeM commented Dec 5, 2024 •
edited
Loading

Proposed changes

  • Decode payload command with rust

  • Bonus

    • fix this problem : the check command was executed even if the check command was an empty string
    • fix this problem : Instantiating a cmd variable and using it in the same line doesn't work as expected. ( this solution go with this PR [backend] handle cmd variables openbas#2001 )

Related issues

@MarineLeM MarineLeM self-assigned this Dec 5, 2024
@MarineLeM MarineLeM mentioned this pull request Dec 5, 2024
Merged
@damgouj damgouj self-requested a review December 5, 2024 13:08
damgouj
damgouj requested changes Dec 6, 2024
View reviewed changes
Copy link
Member

@damgouj damgouj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refacto !

src/process/command_exec.rs Show resolved Hide resolved
src/process/command_exec.rs Show resolved Hide resolved
src/process/command_exec.rs Outdated Show resolved Hide resolved
src/main.rs Outdated Show resolved Hide resolved
@MarineLeM
Copy link
Contributor Author

@damgouj : ready for a second round

@MarineLeM MarineLeM merged commit 404ad50 into release/1.10.0 Dec 10, 2024
5 checks passed
@MarineLeM MarineLeM deleted the issue/1604-chunk-1 branch December 10, 2024 07:33
@MarineLeM MarineLeM linked an issue Dec 19, 2024 that may be closed by this pull request
Ability to choose an obfuscator for your technical inject to avoid detection OpenBAS-Platform/openbas#1604
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damgouj damgouj damgouj approved these changes

Assignees

@MarineLeM MarineLeM

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ability to choose an obfuscator for your technical inject to avoid detection
2 participants
@MarineLeM @damgouj