[implant] Add code quality tools #34
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| pub fn handle_execution_command( | ||
| semantic: &str, | ||
| api: &Client, | ||
| inject_id: String, | ||
| command: &String, | ||
| executor: &String, | ||
| executor: &str, |
There was a problem hiding this comment.
question: Why changing executor type and not command as well ?
| @@ -124,7 +124,7 @@ pub fn handle_payload(inject_id: String, api: &Client, contract_payload: &Inject | |||
| let executor = contract_payload.payload_cleanup_executor.clone().unwrap(); | |||
| let _ = handle_execution_command( | |||
| "cleanup execution", | |||
| &api, | |||
| api, | |||
There was a problem hiding this comment.
If I understand correctly, $api allows you to use the $api variable directly without making a copy.
Wouldn't it be more efficient to keep $api everywhere?
| @@ -106,6 +106,17 @@ jobs: | |||
| - run: sudo apt-get -y install curl musl-tools | |||
| - run: curl https://sh.rustup.rs -sSf | sh -s -- -y | |||
| - run: . "$HOME/.cargo/env"; rustup target add x86_64-unknown-linux-musl | |||
| # Install quality tools | |||
There was a problem hiding this comment.
issue: Can we add the fact of putting the build in error if we have warnings during compilation?
| .expect("Failed to create TLS config with crypto provider"); | ||
| let config = ClientConfig::builder_with_provider(arc_crypto_provider) | ||
| .with_safe_default_protocol_versions() | ||
| .unwrap() |
There was a problem hiding this comment.
question: Can we keep the expect here ?
.expect("Failed to create TLS config with crypto provider")
| let config = ClientConfig::builder_with_provider(arc_crypto_provider) | ||
| .with_safe_default_protocol_versions() | ||
| .unwrap() | ||
| .with_platform_verifier() |
There was a problem hiding this comment.
question: Why adding this line ?
|
Can we take advantage of your PR to push this renovation through? Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Chunck 1:
Add the next code quality tools to CI for Linux & Mac :
→ Cllippy: lint checks https://github.com/rust-lang/rust-clippy
→ Rustfmt: format code
→ Cargo Audit: check security dependencies (Linux, Mac)
→ test
After apply these tools some files were updated.
Related issues
Checklist
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...