[backend/frontend] Prevent users from deleting SP logos (#1660)

OpenBAS-Platform · Oct 18, 2024 · 6143aa4 · 6143aa4
1 parent 10f2d52
commit 6143aa4
Show file tree

Hide file tree

Showing 5 changed files with 21 additions and 3 deletions.
diff --git a/openbas-api/src/main/java/io/openbas/rest/document/DocumentApi.java b/openbas-api/src/main/java/io/openbas/rest/document/DocumentApi.java
@@ -269,13 +269,18 @@ public List<RawDocument> documents() {
     @PostMapping("/api/documents/search")
     public Page<RawPaginationDocument> searchDocuments(@RequestBody @Valid final SearchPaginationInput searchPaginationInput) {
         OpenBASPrincipal user = currentUser();
+        List<Document> securityPlatformLogos = securityPlatformRepository.securityPlatformLogo();
         if (user.isAdmin()) {
             return buildPaginationJPA(
                     (Specification<Document> specification, Pageable pageable) -> this.documentRepository.findAll(
                             specification, pageable),
                     searchPaginationInput,
                     Document.class
-            ).map(RawPaginationDocument::new);
+            ).map((document) -> {
+                var rawPaginationDocument = new RawPaginationDocument(document);
+                rawPaginationDocument.setDocument_can_be_deleted(!securityPlatformLogos.contains(document));
+                return rawPaginationDocument;
+            });
         } else {
             return buildPaginationJPA(
                     (Specification<Document> specification, Pageable pageable) -> this.documentRepository.findAll(
@@ -284,7 +289,11 @@ public Page<RawPaginationDocument> searchDocuments(@RequestBody @Valid final Sea
                     ),
                     searchPaginationInput,
                     Document.class
-            ).map(RawPaginationDocument::new);
+            ).map((document) -> {
+                var rawPaginationDocument = new RawPaginationDocument(document);
+                rawPaginationDocument.setDocument_can_be_deleted(!securityPlatformLogos.contains(document));
+                return rawPaginationDocument;
+            });
         }
     }
 

diff --git a/openbas-front/src/admin/components/components/documents/DocumentPopover.js b/openbas-front/src/admin/components/components/documents/DocumentPopover.js
@@ -164,7 +164,7 @@ const DocumentPopover = (props) => {
           </MenuItem>
         )}
         {!onRemoveDocument && (
-          <MenuItem onClick={handleOpenDelete}>
+          <MenuItem onClick={handleOpenDelete} disabled={!document.document_can_be_deleted}>
             {t('Delete')}
           </MenuItem>
         )}

diff --git a/openbas-front/src/utils/api-types.d.ts b/openbas-front/src/utils/api-types.d.ts
@@ -2598,6 +2598,7 @@ export interface RawDocument {
 }
 
 export interface RawPaginationDocument {
+  document_can_be_deleted?: boolean;
   document_description?: string;
   document_exercises?: string[];
   document_id?: string;

diff --git a/openbas-model/src/main/java/io/openbas/database/raw/RawPaginationDocument.java b/openbas-model/src/main/java/io/openbas/database/raw/RawPaginationDocument.java
@@ -18,6 +18,7 @@ public class RawPaginationDocument {
   List<String> document_scenarios;
   String document_type;
   List<String> document_tags;
+  boolean document_can_be_deleted = true;
 
   public RawPaginationDocument(final Document document) {
     this.document_id = document.getId();

diff --git a/openbas-model/src/main/java/io/openbas/database/repository/SecurityPlatformRepository.java b/openbas-model/src/main/java/io/openbas/database/repository/SecurityPlatformRepository.java
@@ -1,5 +1,6 @@
 package io.openbas.database.repository;
 
+import io.openbas.database.model.Document;
 import io.openbas.database.model.SecurityPlatform;
 import org.springframework.data.jpa.repository.JpaSpecificationExecutor;
 import org.springframework.data.jpa.repository.Query;
@@ -8,6 +9,7 @@
 import org.springframework.stereotype.Repository;
 
 import java.time.Instant;
+import java.util.List;
 import java.util.Optional;
 
 @Repository
@@ -29,4 +31,9 @@ public interface SecurityPlatformRepository extends CrudRepository<SecurityPlatf
   @Override
   @Query("select count(distinct s) from SecurityPlatform s where s.createdAt < :creationDate")
   long globalCount(@Param("creationDate") Instant creationDate);
+
+  @Query("select distinct s.logoDark from SecurityPlatform s " +
+          "union " +
+          "select distinct s.logoLight from SecurityPlatform s ")
+  List<Document> securityPlatformLogo();
 }