Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise the interpolation and obfuscation of commands to the OpenBAS platform level #1831

Closed
RomuDeuxfois opened this issue Nov 8, 2024 · 4 comments · Fixed by #1935 or OpenBAS-Platform/implant#22
Assignees
Labels
feature use for describing a new feature to develop solved The issue has been solved technical improvement Technical refactor or improvement is needed

Comments

@RomuDeuxfois
Copy link
Member

Description

Now

  • OpenBAS put it the job table with the command in plain text
  • The signature mechanics, retrieve this command and encode it
  • The implant retrieves this command, interpolates the arguments and encodes the command

Later

  • OpenBAS feeds the job table with the interpolation and encoding of the command.
  • The signature mechanics recover the command clearly and the command reworked.
  • The implant retrieves the command directly reworked by OpenBAS.
@RomuDeuxfois RomuDeuxfois added bug use for describing something not working as expected needs triage use to identify issue needing triage from Filigran Product team technical improvement Technical refactor or improvement is needed labels Nov 8, 2024
@RomuDeuxfois
Copy link
Member Author

Need to be done before #1604

@jborozco jborozco removed the needs triage use to identify issue needing triage from Filigran Product team label Nov 12, 2024
@jborozco jborozco added this to the Bugs backlog milestone Nov 12, 2024
@MarineLeM MarineLeM self-assigned this Nov 18, 2024
@MarineLeM
Copy link
Contributor

@RomuDeuxfois : Does this issue concerns only payloads of type "command" ?

@RomuDeuxfois
Copy link
Member Author

@RomuDeuxfois : Does this issue concerns only payloads of type "command" ?

All payloads must be affected I think.
If we encode a drop file command, it should also be taken into account.

@MarineLeM MarineLeM linked a pull request Nov 27, 2024 that will close this issue
@EllynBsc EllynBsc added feature use for describing a new feature to develop and removed bug use for describing something not working as expected labels Nov 29, 2024
@EllynBsc EllynBsc modified the milestones: Bugs backlog, Release 1.10.0 Nov 29, 2024
@EllynBsc
Copy link
Member

Discussed with @MarineLeM, tagging this as a feature as it's intertwined with the development of this feature ( cc @jborozco @RomuDeuxfois )

MarineLeM added a commit that referenced this issue Dec 3, 2024
@MarineLeM MarineLeM added the solved The issue has been solved label Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature use for describing a new feature to develop solved The issue has been solved technical improvement Technical refactor or improvement is needed
Projects
None yet
4 participants