Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] send encoded command into implant #1935

Merged
merged 9 commits into from
Dec 3, 2024
Merged

Conversation

MarineLeM
Copy link
Contributor

@MarineLeM MarineLeM commented Nov 27, 2024

Proposed changes

Improvements :

  • Move inject service file under rest>inject>service
  • Remove useless table injects_payloads ( legacy )
  • Remove hardcoded payload type comparisons (replace with enum values).

Code related to the issue :

  • Add new endpoint @GetMapping(INJECT_URI + "/{injectId}/executable-payload")
    used to get payload with encoded command

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion) => in progress
  • Where necessary I refactored code to improve the overall quality

Further comments

⚠️ need to be merge with OpenBAS-Platform/implant#22

@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Nov 27, 2024
@MarineLeM MarineLeM self-assigned this Nov 27, 2024
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 67.08861% with 26 lines in your changes missing coverage. Please review.

Please upload report for BASE (release/1.10.0@ad4a804). Learn more about missing BASE report.
Report is 1 commits behind head on release/1.10.0.

Files with missing lines Patch % Lines
...s/rest/inject/service/ExecutableInjectService.java 68.11% 15 Missing and 7 partials ⚠️
.../main/java/io/openbas/rest/payload/PayloadApi.java 0.00% 1 Missing and 1 partial ⚠️
.../io/openbas/injectors/caldera/CalderaExecutor.java 0.00% 1 Missing ⚠️
...ectors/caldera/service/CalderaInjectorService.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             release/1.10.0    #1935   +/-   ##
=================================================
  Coverage                  ?   34.27%           
  Complexity                ?     1712           
=================================================
  Files                     ?      574           
  Lines                     ?    16792           
  Branches                  ?      977           
=================================================
  Hits                      ?     5755           
  Misses                    ?    10770           
  Partials                  ?      267           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MarineLeM
Copy link
Contributor Author

@Dimfacion I took into account your observations. Please let me know if you notice anything else. Thank you!🙏

@MarineLeM MarineLeM changed the base branch from master to release/1.10.0 December 3, 2024 08:27
Signed-off-by: Marine LM <[email protected]>
@MarineLeM MarineLeM merged commit 62aec5d into release/1.10.0 Dec 3, 2024
6 checks passed
@MarineLeM MarineLeM deleted the issue/1831 branch December 3, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Raise the interpolation and obfuscation of commands to the OpenBAS platform level
3 participants