Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] fix deadlock flyway migration on 9.22.3 #1358

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

savacano28
Copy link
Contributor

@savacano28 savacano28 commented Aug 29, 2024

Proposed changes

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@savacano28 savacano28 self-assigned this Aug 29, 2024
@savacano28 savacano28 added the filigran team use to identify PR from the Filigran team label Aug 29, 2024
@savacano28 savacano28 marked this pull request as ready for review August 29, 2024 07:07
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.87%. Comparing base (2e610f0) to head (769b159).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1358   +/-   ##
=========================================
  Coverage     28.87%   28.87%           
  Complexity     1323     1323           
=========================================
  Files           526      526           
  Lines         13721    13721           
  Branches        811      811           
=========================================
  Hits           3962     3962           
  Misses         9574     9574           
  Partials        185      185           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@savacano28 savacano28 force-pushed the issue/flyway-locked-migrations branch from 7b67ff6 to bd7d710 Compare August 29, 2024 10:30
@EllynBsc
Copy link
Member

@savacano28, following our discussion from this morning, this PR will solve #1361

@guillaumejparis guillaumejparis added the do not merge Do not merge this PR until this tag will be removed label Aug 30, 2024
@savacano28 savacano28 force-pushed the issue/flyway-locked-migrations branch from bd7d710 to 646ceea Compare August 30, 2024 12:19
@guillaumejparis guillaumejparis linked an issue Aug 30, 2024 that may be closed by this pull request
@savacano28 savacano28 force-pushed the issue/flyway-locked-migrations branch from 646ceea to 0d0951b Compare September 4, 2024 12:52
@RomuDeuxfois
Copy link
Member

Test in local 🆗

@savacano28 savacano28 force-pushed the issue/flyway-locked-migrations branch from 0d0951b to 769b159 Compare September 5, 2024 09:32
@savacano28 savacano28 merged commit 9636a6c into master Sep 5, 2024
7 checks passed
@savacano28 savacano28 removed the do not merge Do not merge this PR until this tag will be removed label Sep 5, 2024
@savacano28 savacano28 deleted the issue/flyway-locked-migrations branch September 9, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid deadlocks during Flyway migrations (>9.0.)
5 participants