Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] add a warning instead of loading indefinitely on 404 for s… #1369

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

guillaumejparis
Copy link
Member

…imulation & scenario (#844)

Close #844

@guillaumejparis guillaumejparis added the filigran team use to identify PR from the Filigran team label Aug 30, 2024
Copy link

codecov bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.18%. Comparing base (47dbce5) to head (e895251).
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1369      +/-   ##
============================================
+ Coverage     28.64%   29.18%   +0.54%     
- Complexity     1319     1336      +17     
============================================
  Files           526      526              
  Lines         13721    13721              
  Branches        811      811              
============================================
+ Hits           3930     4005      +75     
+ Misses         9606     9523      -83     
- Partials        185      193       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@guillaumejparis guillaumejparis force-pushed the issue/844 branch 2 times, most recently from 1124b9b to 031734c Compare September 3, 2024 13:55
@guillaumejparis guillaumejparis merged commit 2e610f0 into master Sep 4, 2024
7 checks passed
@guillaumejparis guillaumejparis deleted the issue/844 branch September 4, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

404 errors are not correctly handles, leading to spinning forever
2 participants