Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Small fix on chaining UI #1448

Merged
merged 2 commits into from
Sep 16, 2024
Merged

Conversation

Dimfacion
Copy link
Member

@Dimfacion Dimfacion commented Sep 16, 2024

Proposed changes

  • Adding a small padding on the condition
  • Better message in the condition form

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Sep 16, 2024
Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 31.08%. Comparing base (6e782f9) to head (6047c1f).
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1448      +/-   ##
============================================
- Coverage     31.32%   31.08%   -0.24%     
+ Complexity     1400     1396       -4     
============================================
  Files           526      526              
  Lines         13693    13693              
  Branches        814      814              
============================================
- Hits           4289     4257      -32     
- Misses         9204     9236      +32     
  Partials        200      200              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dimfacion Dimfacion merged commit 808cc48 into master Sep 16, 2024
7 checks passed
@Dimfacion Dimfacion deleted the bugfix/chaining-ui-fix branch September 18, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants