Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend/frontend] Command Details in execution traces (#1232) #1449

Merged
merged 10 commits into from
Sep 18, 2024

Conversation

damgouj
Copy link
Member

@damgouj damgouj commented Sep 16, 2024

Proposed changes

  • Display initial command line in execution details tab
  • Update the Front to add the new section "Command lines"
  • Update the Back/Database to add command lines for each inject
  • Add Integration test for AtomicTestingApi

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

@damgouj damgouj self-assigned this Sep 16, 2024
@damgouj damgouj linked an issue Sep 16, 2024 that may be closed by this pull request
@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Sep 16, 2024
Copy link

codecov bot commented Sep 16, 2024

Codecov Report

Attention: Patch coverage is 29.16667% with 34 lines in your changes missing coverage. Please review.

Project coverage is 32.24%. Comparing base (d197cea) to head (50ea161).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
.../io/openbas/injectors/caldera/CalderaExecutor.java 0.00% 15 Missing ⚠️
.../java/io/openbas/service/AtomicTestingService.java 52.94% 5 Missing and 3 partials ⚠️
...io/openbas/scheduler/jobs/InjectsExecutionJob.java 0.00% 5 Missing ⚠️
...njectors/caldera/client/CalderaInjectorClient.java 0.00% 4 Missing ⚠️
...enbas/injectors/caldera/client/model/Executor.java 0.00% 1 Missing ⚠️
...ectors/caldera/service/CalderaInjectorService.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1449      +/-   ##
============================================
+ Coverage     31.34%   32.24%   +0.90%     
- Complexity     1408     1451      +43     
============================================
  Files           531      532       +1     
  Lines         13751    13798      +47     
  Branches        815      821       +6     
============================================
+ Hits           4310     4449     +139     
+ Misses         9241     9143      -98     
- Partials        200      206       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johanah29
Copy link
Member

johanah29 commented Sep 16, 2024

Should rename your migration fille to 3.37 as 3.35 and 3.36 were merged on master

@damgouj damgouj force-pushed the issue/1232 branch 4 times, most recently from 1088729 to 9d1fadb Compare September 17, 2024 06:48
@guillaumejparis guillaumejparis self-requested a review September 17, 2024 07:50
Comment on lines -178 to -181
'pre.light': {
fontFamily: 'Consolas, monaco, monospace',
background: `${nav || '#071a2e'} !important`,
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not used anymore ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't find it in the code and there are two files to manage the themes (there is a pre "light" in ThemeLight.ts)

Copy link
Member

@guillaumejparis guillaumejparis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems weird to display commands lines without at least which platform they are for
image

@damgouj
Copy link
Member Author

damgouj commented Sep 17, 2024

Seems weird to display commands lines without at least which platform they are for image

Seen with JB : It's just to inform the user, we keep it like that and we'll see if there are remarks in the future.

@damgouj damgouj changed the title [backend/frontend] Command Details in execution traces [backend/frontend] Command Details in execution traces (#1232) Sep 18, 2024
@damgouj damgouj merged commit 900923f into master Sep 18, 2024
7 checks passed
@damgouj damgouj deleted the issue/1232 branch September 18, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Command Details in execution traces
3 participants