Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend]Fix the display of the result of injects bulk deletion #1481

Merged
merged 4 commits into from
Sep 25, 2024

Conversation

johanah29
Copy link
Member

@johanah29 johanah29 self-assigned this Sep 19, 2024
@johanah29 johanah29 linked an issue Sep 19, 2024 that may be closed by this pull request
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 32.55%. Comparing base (7142c8b) to head (95bcf89).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1481   +/-   ##
=========================================
  Coverage     32.55%   32.55%           
  Complexity     1464     1464           
=========================================
  Files           534      534           
  Lines         13766    13766           
  Branches        824      824           
=========================================
  Hits           4482     4482           
  Misses         9075     9075           
  Partials        209      209           
Flag Coverage Δ
32.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

const injectContract = inject.inject_injector_contract?.convertedContent;
const isContractExposed = injectContract?.config.expose;
return (
<ListItemButton
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can't do that
Check this screenshot
image

VS
image

@RomuDeuxfois
Copy link
Member

Tested 🆗

@johanah29 johanah29 merged commit a86d17a into master Sep 25, 2024
7 checks passed
@johanah29 johanah29 deleted the bug/1471 branch September 25, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bulk deletion of inject only delete the first one of the list
2 participants