Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] Fix null field in import #1512

Merged
merged 3 commits into from
Sep 26, 2024
Merged

[backend] Fix null field in import #1512

merged 3 commits into from
Sep 26, 2024

Conversation

RomuDeuxfois
Copy link
Member

@RomuDeuxfois RomuDeuxfois commented Sep 23, 2024

Proposed changes

  • Improv property extraction to avoid null values

@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Sep 23, 2024
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 7.69231% with 12 lines in your changes missing coverage. Please review.

Project coverage is 32.53%. Comparing base (647b5a2) to head (00d6514).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...main/java/io/openbas/importer/V1_DataImporter.java 0.00% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1512   +/-   ##
=========================================
  Coverage     32.53%   32.53%           
  Complexity     1464     1464           
=========================================
  Files           534      534           
  Lines         13777    13775    -2     
  Branches        824      818    -6     
=========================================
  Hits           4482     4482           
+ Misses         9086     9084    -2     
  Partials        209      209           
Flag Coverage Δ
32.53% <7.69%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@isselparra isselparra self-requested a review September 25, 2024 07:35
Copy link
Contributor

@isselparra isselparra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional test OK

Regression detected: there seems to be a regression regarding the creation of an Scenario, when a severity is specified, on the UI it appears as "Unknown". Also the severity attribute (scenario_severity in the json) is "null" after the export of an recently created Scenario. cc @RomuDeuxfois

@RomuDeuxfois
Copy link
Member Author

I fix the regression @isselparra

Copy link
Contributor

@isselparra isselparra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test OK

  • The Severity regression is not present anymore
  • On import/export the severity was taken into account

@RomuDeuxfois RomuDeuxfois merged commit ea3d549 into master Sep 26, 2024
7 checks passed
@RomuDeuxfois RomuDeuxfois deleted the bugfix/import branch September 26, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants