-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[backend] Fix null field in import #1512
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1512 +/- ##
=========================================
Coverage 32.53% 32.53%
Complexity 1464 1464
=========================================
Files 534 534
Lines 13777 13775 -2
Branches 824 818 -6
=========================================
Hits 4482 4482
+ Misses 9086 9084 -2
Partials 209 209
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional test OK
Regression detected: there seems to be a regression regarding the creation of an Scenario, when a severity is specified, on the UI it appears as "Unknown". Also the severity attribute (scenario_severity in the json) is "null" after the export of an recently created Scenario. cc @RomuDeuxfois
I fix the regression @isselparra |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test OK
- The Severity regression is not present anymore
- On import/export the severity was taken into account
Proposed changes