Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] fix constraint on delete set null to cascade #1532

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

savacano28
Copy link
Contributor

@savacano28 savacano28 commented Sep 25, 2024

Proposed changes

  • Modify constraint on delete for inject importers ans rule attributs

Related issues

  • After modification on injectorService l77, when we make a deletebyId, I found a fk error :
    image

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@savacano28 savacano28 added the filigran team use to identify PR from the Filigran team label Sep 25, 2024
@savacano28 savacano28 self-assigned this Sep 25, 2024
@savacano28 savacano28 marked this pull request as ready for review September 25, 2024 11:48
@savacano28 savacano28 force-pushed the bugfix/modify-on-delete-cascade-constraint branch from 82360b9 to 8c85969 Compare September 25, 2024 11:48
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 32.58%. Comparing base (ee7f6df) to head (8c85969).
Report is 10 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1532      +/-   ##
============================================
+ Coverage     32.53%   32.58%   +0.04%     
- Complexity     1464     1466       +2     
============================================
  Files           534      535       +1     
  Lines         13777    13787      +10     
  Branches        824      824              
============================================
+ Hits           4482     4492      +10     
  Misses         9086     9086              
  Partials        209      209              
Flag Coverage Δ
32.58% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@savacano28 savacano28 merged commit 5d42857 into master Sep 26, 2024
7 checks passed
@savacano28 savacano28 deleted the bugfix/modify-on-delete-cascade-constraint branch October 2, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants