Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] fix filter priority order o #1534

Closed
wants to merge 17 commits into from

Conversation

savacano28
Copy link
Contributor

@savacano28 savacano28 commented Sep 25, 2024

Proposed changes

  • Add default values for status, source on paylaod relation
  • Fix filter for enumerated types : Add operator: empty, no_empty to enumerate types
    Screenshot 2024-09-25 143940
    image

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@savacano28 savacano28 self-assigned this Sep 25, 2024
@savacano28 savacano28 added the filigran team use to identify PR from the Filigran team label Sep 25, 2024
@savacano28 savacano28 marked this pull request as ready for review September 25, 2024 12:45
@savacano28 savacano28 linked an issue Sep 25, 2024 that may be closed by this pull request
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 32.45%. Comparing base (ab25dcf) to head (73c4b25).

Files with missing lines Patch % Lines
.../openbas/rest/payload/form/PayloadCreateInput.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1534      +/-   ##
============================================
+ Coverage     32.41%   32.45%   +0.03%     
- Complexity     1506     1508       +2     
============================================
  Files           544      545       +1     
  Lines         14071    14079       +8     
  Branches        843      843              
============================================
+ Hits           4561     4569       +8     
  Misses         9296     9296              
  Partials        214      214              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@savacano28 savacano28 marked this pull request as draft September 26, 2024 06:36
@savacano28 savacano28 force-pushed the bugfix/1478-fix-filter-order branch from 65444c5 to 8a27198 Compare September 26, 2024 16:05
@savacano28 savacano28 marked this pull request as ready for review September 27, 2024 14:40
@savacano28 savacano28 force-pushed the bugfix/1478-fix-filter-order branch from 42508c4 to cbc4dc8 Compare September 27, 2024 14:40
Copy link
Member

@damgouj damgouj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :) !

@savacano28 savacano28 requested review from RomuDeuxfois and removed request for RomuDeuxfois September 27, 2024 15:10
@savacano28 savacano28 marked this pull request as draft September 27, 2024 15:23
@savacano28 savacano28 requested a review from damgouj September 30, 2024 07:42
@savacano28 savacano28 force-pushed the bugfix/1478-fix-filter-order branch from e4487f7 to 729a7ce Compare September 30, 2024 08:48
@savacano28 savacano28 marked this pull request as ready for review September 30, 2024 08:59
Copy link
Member

@damgouj damgouj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have still an error when I test (for example : Payload Page, Filter Status=UNVERIFIED doesn't work). Other screens seem OK :).

@savacano28 savacano28 force-pushed the bugfix/1478-fix-filter-order branch from 900034b to 54f9f7a Compare October 1, 2024 15:43
@savacano28 savacano28 requested a review from damgouj October 1, 2024 15:49
@savacano28 savacano28 force-pushed the bugfix/1478-fix-filter-order branch from ce6bafd to fa2957e Compare October 2, 2024 11:33
@RomuDeuxfois
Copy link
Member

RomuDeuxfois commented Oct 2, 2024

When I try to filter on Unverified status
image
Nothing happened
image

This is because, on the front-end if the status is empty we display Unverified.
image

I think we need to manage this filter with something like handleCustomFilter or have a migration to always have Unverified in DB ?
We have the same problem with source

@savacano28 savacano28 marked this pull request as draft October 2, 2024 13:43
@savacano28 savacano28 force-pushed the bugfix/1478-fix-filter-order branch from febb01a to 7a4f20f Compare October 2, 2024 15:23
@savacano28 savacano28 marked this pull request as ready for review October 2, 2024 15:54
@savacano28 savacano28 force-pushed the bugfix/1478-fix-filter-order branch 3 times, most recently from 4b48fe2 to e824590 Compare October 3, 2024 11:01
@savacano28 savacano28 removed the request for review from RomuDeuxfois October 3, 2024 15:12
@savacano28 savacano28 force-pushed the bugfix/1478-fix-filter-order branch from e824590 to 784aa10 Compare October 3, 2024 15:13
@savacano28 savacano28 force-pushed the bugfix/1478-fix-filter-order branch from b5ae029 to 8155318 Compare October 4, 2024 11:51
@savacano28
Copy link
Contributor Author

@RomuDeuxfois I've added the fixes. Thank you!

@savacano28 savacano28 changed the title [frontend] fix filter priority order [frontend] fix filter priority order o Oct 7, 2024
@savacano28 savacano28 closed this Oct 7, 2024
@savacano28 savacano28 deleted the bugfix/1478-fix-filter-order branch October 16, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken filter in payloads list
3 participants