-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[frontend] fix filter priority order o #1534
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1534 +/- ##
============================================
+ Coverage 32.41% 32.45% +0.03%
- Complexity 1506 1508 +2
============================================
Files 544 545 +1
Lines 14071 14079 +8
Branches 843 843
============================================
+ Hits 4561 4569 +8
Misses 9296 9296
Partials 214 214 ☔ View full report in Codecov by Sentry. |
openbas-front/src/components/common/queryable/filter/FilterUtils.tsx
Outdated
Show resolved
Hide resolved
65444c5
to
8a27198
Compare
42508c4
to
cbc4dc8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks :) !
e4487f7
to
729a7ce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have still an error when I test (for example : Payload Page, Filter Status=UNVERIFIED doesn't work). Other screens seem OK :).
openbas-api/src/test/java/io/openbas/utils/fixtures/PayloadFixture.java
Outdated
Show resolved
Hide resolved
900034b
to
54f9f7a
Compare
ce6bafd
to
fa2957e
Compare
openbas-api/src/main/java/io/openbas/rest/payload/form/PayloadCreateInput.java
Show resolved
Hide resolved
openbas-front/src/components/common/queryable/filter/FilterUtils.tsx
Outdated
Show resolved
Hide resolved
febb01a
to
7a4f20f
Compare
4b48fe2
to
e824590
Compare
e824590
to
784aa10
Compare
b5ae029
to
8155318
Compare
@RomuDeuxfois I've added the fixes. Thank you! |
Proposed changes
Related issues
Checklist
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...