-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[backend/frontend] Fix removing a team from the context doesn't work #1544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
filigran team
use to identify PR from the Filigran team
label
Sep 25, 2024
RomuDeuxfois
force-pushed
the
issue/1521
branch
2 times, most recently
from
October 2, 2024 17:35
8eebe8c
to
4ae7d03
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1544 +/- ##
============================================
+ Coverage 33.28% 33.32% +0.04%
Complexity 1605 1605
============================================
Files 557 557
Lines 14474 14476 +2
Branches 871 871
============================================
+ Hits 4817 4824 +7
+ Misses 9435 9431 -4
+ Partials 222 221 -1 ☔ View full report in Codecov by Sentry. |
MarineLeM
reviewed
Oct 16, 2024
openbas-api/src/main/java/io/openbas/rest/exercise/ExerciseService.java
Outdated
Show resolved
Hide resolved
openbas-api/src/main/java/io/openbas/service/ScenarioService.java
Outdated
Show resolved
Hide resolved
openbas-api/src/test/java/io/openbas/service/ExerciseServiceTest.java
Outdated
Show resolved
Hide resolved
openbas-api/src/test/java/io/openbas/service/ScenarioServiceTest.java
Outdated
Show resolved
Hide resolved
RomuDeuxfois
force-pushed
the
issue/1521
branch
from
October 16, 2024 15:07
4ae7d03
to
a308820
Compare
Need to be retest by me before review |
All good :) |
MarineLeM
approved these changes
Oct 17, 2024
RomuDeuxfois
force-pushed
the
issue/1521
branch
from
October 19, 2024 13:01
0f74d2a
to
52e788f
Compare
RomuDeuxfois
force-pushed
the
issue/1521
branch
from
October 19, 2024 13:02
52e788f
to
eb00fe0
Compare
RomuDeuxfois
force-pushed
the
issue/1521
branch
from
October 19, 2024 13:04
eb00fe0
to
84f60ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1521
Proposed changes
Related issues
Checklist
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...