Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend/frontend] Fix removing a team from the context doesn't work #1544

Merged
merged 6 commits into from
Oct 19, 2024

Conversation

RomuDeuxfois
Copy link
Member

@RomuDeuxfois RomuDeuxfois commented Sep 25, 2024

Closes #1521

Proposed changes

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Sep 25, 2024
@RomuDeuxfois RomuDeuxfois force-pushed the issue/1521 branch 2 times, most recently from 8eebe8c to 4ae7d03 Compare October 2, 2024 17:35
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 76.47059% with 4 lines in your changes missing coverage. Please review.

Project coverage is 33.32%. Comparing base (9274617) to head (7408aab).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...openbas/rest/exercise/service/ExerciseService.java 75.00% 2 Missing and 1 partial ⚠️
...ain/java/io/openbas/rest/exercise/ExerciseApi.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1544      +/-   ##
============================================
+ Coverage     33.28%   33.32%   +0.04%     
  Complexity     1605     1605              
============================================
  Files           557      557              
  Lines         14474    14476       +2     
  Branches        871      871              
============================================
+ Hits           4817     4824       +7     
+ Misses         9435     9431       -4     
+ Partials        222      221       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RomuDeuxfois RomuDeuxfois marked this pull request as ready for review October 2, 2024 17:44
@MarineLeM MarineLeM self-requested a review October 14, 2024 15:07
@RomuDeuxfois
Copy link
Member Author

RomuDeuxfois commented Oct 16, 2024

Need to be retest by me before review

@RomuDeuxfois
Copy link
Member Author

All good :)
Ready for a second round

@RomuDeuxfois RomuDeuxfois merged commit 0f6cfee into master Oct 19, 2024
7 checks passed
@RomuDeuxfois RomuDeuxfois deleted the issue/1521 branch October 19, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Removing a team from the context doesn't work
2 participants