Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend/backend] Chaining injects logically #1551

Merged
merged 34 commits into from
Oct 23, 2024
Merged

[frontend/backend] Chaining injects logically #1551

merged 34 commits into from
Oct 23, 2024

Conversation

Dimfacion
Copy link
Member

@Dimfacion Dimfacion commented Sep 27, 2024

Proposed changes

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Sep 30, 2024
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 20.95808% with 132 lines in your changes missing coverage. Please review.

Project coverage is 33.22%. Comparing base (55d481f) to head (5db2b2d).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
...io/openbas/scheduler/jobs/InjectsExecutionJob.java 1.56% 63 Missing ⚠️
...rc/main/java/io/openbas/rest/inject/InjectApi.java 24.48% 33 Missing and 4 partials ⚠️
...igration/V3_46__Add_table_inject_dependencies.java 34.78% 14 Missing and 1 partial ⚠️
.../io/openbas/service/ScenarioToExerciseService.java 33.33% 6 Missing ⚠️
...nbas/rest/inject/form/InjectDependencyIdInput.java 0.00% 4 Missing ⚠️
...penbas/rest/inject/form/InjectDependencyInput.java 0.00% 4 Missing ⚠️
...va/io/openbas/rest/inject/output/InjectOutput.java 50.00% 1 Missing and 1 partial ⚠️
.../java/io/openbas/service/AtomicTestingService.java 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1551      +/-   ##
============================================
- Coverage     33.52%   33.22%   -0.30%     
- Complexity     1608     1613       +5     
============================================
  Files           557      560       +3     
  Lines         14477    14719     +242     
  Branches        871      910      +39     
============================================
+ Hits           4854     4891      +37     
- Misses         9398     9597     +199     
- Partials        225      231       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dimfacion Dimfacion closed this Oct 11, 2024
@Dimfacion Dimfacion reopened this Oct 11, 2024
@Dimfacion Dimfacion marked this pull request as ready for review October 12, 2024 22:50
@RomuDeuxfois RomuDeuxfois self-requested a review October 15, 2024 14:53
@RomuDeuxfois
Copy link
Member

RomuDeuxfois commented Oct 15, 2024

FIX ✅
When I update an inject with a relation, the arrow disappear in the timeline:
image
image
image

FIX ✅
Can we display the condition we need ? And explain that it's a condition from inject dependencies and not condition from content or something else. It can be confusing.
image
Example of other error: ERROR The inject is not ready to be executed (missing mandatory fields)

FIX ✅
When I re update my inject, the dropdown is not containing the possibilities (I have only one parent and one child in my case)
image

I can add multiple time the same condition, it's normal ?
image

Tests:
Inject A -Execution is success > Inject B 🆗
Inject A -Execution is failed > Inject B 🆗
Inject A -Execution is success AND Manual expectation is Fail > Inject B 🆗
Inject A -Execution is success AND Manual expectation is Success > Inject B 🆗

@Dimfacion
Copy link
Member Author

@RomuDeuxfois I added an explanation and the list of expectations required :
Screenshot from 2024-10-16 15-59-35
I also have fixed the issues you talked about. As for the possibility of adding lots of condition, there are no control right now. I'll check with JB if it's a nice to have or mandatory

@Dimfacion Dimfacion merged commit f4ae81f into master Oct 23, 2024
5 checks passed
@Dimfacion Dimfacion deleted the issue/1385 branch October 23, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants