Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] Fix 401 when user not admin and go to page with filters #1620

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

damgouj
Copy link
Member

@damgouj damgouj commented Oct 4, 2024

Proposed changes

  • When an user is not admin, allow him to see pages with filters (like scenarios and simulations)

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

@damgouj damgouj requested a review from RomuDeuxfois October 4, 2024 09:08
@damgouj damgouj self-assigned this Oct 4, 2024
@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Oct 4, 2024
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 32.41%. Comparing base (0f8cf4e) to head (334672e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1620      +/-   ##
============================================
- Coverage     32.43%   32.41%   -0.03%     
+ Complexity     1507     1506       -1     
============================================
  Files           544      544              
  Lines         14071    14071              
  Branches        843      843              
============================================
- Hits           4564     4561       -3     
- Misses         9293     9296       +3     
  Partials        214      214              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@damgouj damgouj merged commit ab25dcf into master Oct 4, 2024
7 checks passed
@damgouj damgouj deleted the bugfix/schema_filter_admin branch October 4, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants