Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] Format code with Spotless #1634

Merged
merged 2 commits into from
Oct 28, 2024
Merged

[backend] Format code with Spotless #1634

merged 2 commits into from
Oct 28, 2024

Conversation

isselparra
Copy link
Contributor

@isselparra isselparra commented Oct 11, 2024

Proposed changes

  • Add spotless plugin

mvn spotless:check

mvn spotless:apply

@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Oct 11, 2024
@isselparra isselparra force-pushed the tooling/add-spotless branch 2 times, most recently from cb47a2d to ff54bae Compare October 16, 2024 08:28
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 31.25320% with 2688 lines in your changes missing coverage. Please review.

Project coverage is 32.24%. Comparing base (63d029e) to head (0142a5c).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
.../io/openbas/injectors/caldera/CalderaExecutor.java 0.00% 265 Missing ⚠️
...io/openbas/injectors/lade/service/LadeService.java 1.91% 205 Missing ⚠️
...nbas/injectors/openbas/OpenBASImplantExecutor.java 0.00% 184 Missing ⚠️
...o/openbas/injectors/email/service/ImapService.java 18.26% 168 Missing and 2 partials ⚠️
...main/java/io/openbas/importer/V1_DataImporter.java 34.46% 147 Missing and 7 partials ⚠️
...ectors/caldera/service/CalderaInjectorService.java 0.00% 136 Missing ⚠️
...njectors/caldera/client/CalderaInjectorClient.java 0.89% 111 Missing ⚠️
...caldera/service/CalderaResultCollectorService.java 5.45% 104 Missing ⚠️
...cutors/caldera/service/CalderaExecutorService.java 8.84% 102 Missing and 1 partial ⚠️
.../openbas/rest/attack_pattern/AttackPatternApi.java 6.97% 80 Missing ⚠️
... and 74 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1634      +/-   ##
============================================
- Coverage     33.17%   32.24%   -0.93%     
- Complexity     1600     1609       +9     
============================================
  Files           561      561              
  Lines         14649    16755    +2106     
  Branches        896      963      +67     
============================================
+ Hits           4860     5403     +543     
- Misses         9558    11108    +1550     
- Partials        231      244      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@isselparra isselparra force-pushed the tooling/add-spotless branch from 02f797c to a756c85 Compare October 17, 2024 07:49
@isselparra isselparra changed the title [backend] Add spotless [backend] Add Spotless Oct 17, 2024
@isselparra isselparra force-pushed the tooling/add-spotless branch 2 times, most recently from 80e5909 to f7da295 Compare October 17, 2024 08:07
@isselparra isselparra force-pushed the tooling/add-spotless branch 4 times, most recently from b47e0da to 2053994 Compare October 24, 2024 13:03
@isselparra isselparra force-pushed the tooling/add-spotless branch from 2053994 to 0142a5c Compare October 28, 2024 08:24
@isselparra isselparra marked this pull request as ready for review October 28, 2024 08:24
@isselparra isselparra changed the title [backend] Add Spotless [backend] Format code with Spotless Oct 28, 2024
@isselparra isselparra merged commit 8117811 into master Oct 28, 2024
7 checks passed
@isselparra isselparra deleted the tooling/add-spotless branch October 28, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants