Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] Improve latency on simulations list with filters #1665

Merged
merged 7 commits into from
Nov 4, 2024

Conversation

savacano28
Copy link
Contributor

@savacano28 savacano28 commented Oct 17, 2024

Proposed changes

  • Delete duplicated joins

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@savacano28 savacano28 closed this Oct 17, 2024
@savacano28 savacano28 deleted the issue/1582-3 branch October 17, 2024 16:04
@savacano28 savacano28 restored the issue/1582-3 branch October 18, 2024 09:57
@savacano28 savacano28 reopened this Oct 18, 2024
@savacano28 savacano28 self-assigned this Oct 21, 2024
@savacano28 savacano28 added the filigran team use to identify PR from the Filigran team label Oct 21, 2024
Copy link

codecov bot commented Oct 25, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 32.09%. Comparing base (79b8230) to head (2cee594).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
.../io/openbas/rest/scenario/ScenarioExerciseApi.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1665      +/-   ##
============================================
+ Coverage     32.07%   32.09%   +0.01%     
- Complexity     1609     1610       +1     
============================================
  Files           561      561              
  Lines         16845    16851       +6     
  Branches        973      974       +1     
============================================
+ Hits           5403     5408       +5     
- Misses        11198    11199       +1     
  Partials        244      244              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johanah29 johanah29 force-pushed the issue/1582-3 branch 2 times, most recently from 3e72ed8 to c05e1d3 Compare October 29, 2024 09:06
@johanah29 johanah29 changed the title [backend] Add join map [backend] Improve latency on silulations list with filters Oct 29, 2024
@johanah29 johanah29 marked this pull request as ready for review October 29, 2024 09:13
@savacano28 savacano28 changed the title [backend] Improve latency on silulations list with filters [backend] Improve latency on simulations list with filters Oct 29, 2024
@RomuDeuxfois RomuDeuxfois merged commit ab8da71 into master Nov 4, 2024
7 checks passed
@RomuDeuxfois RomuDeuxfois deleted the issue/1582-3 branch November 4, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve latency on simulations list
3 participants