Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] Add index for expectations #1669

Merged
merged 2 commits into from
Oct 17, 2024
Merged

[backend] Add index for expectations #1669

merged 2 commits into from
Oct 17, 2024

Conversation

savacano28
Copy link
Contributor

@savacano28 savacano28 commented Oct 17, 2024

Proposed changes

  • Add index on expectations

Related issues

  • Closes #ISSUE-NUMBER

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@savacano28 savacano28 self-assigned this Oct 17, 2024
@savacano28 savacano28 added the filigran team use to identify PR from the Filigran team label Oct 17, 2024
@savacano28 savacano28 marked this pull request as ready for review October 17, 2024 12:57
@savacano28 savacano28 marked this pull request as draft October 17, 2024 12:59
@savacano28 savacano28 changed the title [backend] Add index for expectations on inject attribut [backend] Add index for expectations Oct 17, 2024
@savacano28 savacano28 marked this pull request as ready for review October 17, 2024 13:05
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.15%. Comparing base (5874aaf) to head (cce83f8).
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1669      +/-   ##
============================================
+ Coverage     33.11%   33.15%   +0.04%     
- Complexity     1584     1586       +2     
============================================
  Files           550      551       +1     
  Lines         14421    14431      +10     
  Branches        873      873              
============================================
+ Hits           4775     4785      +10     
  Misses         9425     9425              
  Partials        221      221              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@savacano28 savacano28 merged commit 3e16a92 into master Oct 17, 2024
7 checks passed
@savacano28 savacano28 deleted the issue/1583-index branch October 20, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants