Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend/frontend] Prevent users from deleting SP logos (#1660) #1676

Merged
merged 2 commits into from
Oct 23, 2024

Conversation

Dimfacion
Copy link
Member

@Dimfacion Dimfacion commented Oct 17, 2024

Proposed changes

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Oct 17, 2024
@Dimfacion Dimfacion force-pushed the issue/1660 branch 3 times, most recently from be78a55 to 9715df6 Compare October 17, 2024 23:02
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 8.21918% with 268 lines in your changes missing coverage. Please review.

Project coverage is 33.25%. Comparing base (10f2d52) to head (23a1ca7).
Report is 23 commits behind head on master.

Files with missing lines Patch % Lines
...ain/java/io/openbas/rest/document/DocumentApi.java 8.21% 268 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1676      +/-   ##
============================================
- Coverage     33.28%   33.25%   -0.03%     
  Complexity     1605     1605              
============================================
  Files           557      557              
  Lines         14474    14486      +12     
  Branches        871      872       +1     
============================================
  Hits           4817     4817              
- Misses         9435     9447      +12     
  Partials        222      222              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@savacano28 savacano28 self-requested a review October 18, 2024 07:19
@Dimfacion Dimfacion merged commit 8768b3e into master Oct 23, 2024
7 checks passed
@Dimfacion Dimfacion deleted the issue/1660 branch October 23, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Images (logos) of security systems uploaded by collectors should not be deletable
3 participants