Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] Simulations never ends if no inject / disabled injects / deleted injects (#1586) #1711

Merged
merged 2 commits into from
Oct 23, 2024

Conversation

isselparra
Copy link
Contributor

@isselparra isselparra commented Oct 21, 2024

Proposed changes

  • Handle inject with no injector contract

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • Where necessary I refactored code to improve the overall quality

@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Oct 21, 2024
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 59 lines in your changes missing coverage. Please review.

Project coverage is 33.52%. Comparing base (55d481f) to head (3d525b2).
Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
...io/openbas/scheduler/jobs/InjectsExecutionJob.java 0.00% 59 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1711      +/-   ##
============================================
- Coverage     33.52%   33.52%   -0.01%     
- Complexity     1608     1658      +50     
============================================
  Files           557      561       +4     
  Lines         14477    15023     +546     
  Branches        871      947      +76     
============================================
+ Hits           4854     5037     +183     
- Misses         9398     9753     +355     
- Partials        225      233       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@isselparra isselparra marked this pull request as ready for review October 22, 2024 08:36
@savacano28 savacano28 self-requested a review October 22, 2024 09:07
@isselparra isselparra changed the title [backend] Simulations never ends if no inject / disabled injects / deleted injects [backend] Simulations never ends if no inject / disabled injects / deleted injects (#1586) Oct 23, 2024
@isselparra isselparra merged commit 7273c2c into master Oct 23, 2024
7 checks passed
@guillaumejparis guillaumejparis deleted the issue/1586 branch October 23, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simulations never ends if no inject / disabled injects / deleted injects
3 participants